Docker/AdventureLog
Docker/AdventureLog
1
0
Fork 0
mirror of https://github.com/seanmorley15/AdventureLog.git synced 2025-07-23 14:59:36 +02:00
Code Issues Releases Activity

feat: Enhance session cookie domain handling for IP addresses and single-label hostnames

Browse source
This commit is contained in:
Sean Morley 2025-02-20 10:21:48 -05:00
parent 7cea432353
commit 1c15e85986
4 changed files with 18 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
backend/server/main/settings.py
View file

@ -135,17 +135,14 @@ SESSION_COOKIE_SAMESITE = 'Lax'
SESSION_COOKIE_SECURE = FRONTEND_URL.startswith('https')
# Parse the FRONTEND_URL
# Remove and ' from the URL
parsed_url = urlparse(FRONTEND_URL)
hostname = parsed_url.hostname
# Check if the hostname is an IP address
hostname = urlparse(FRONTEND_URL).hostname
is_ip_address = hostname.replace('.', '').isdigit()
if is_ip_address:
# Do not set a domain for IP addresses
# Check if the hostname is single-label (no dots)
is_single_label = '.' not in hostname
if is_ip_address or is_single_label:
# Do not set a domain for IP addresses or single-label hostnames
SESSION_COOKIE_DOMAIN = None
else:
# Use publicsuffix2 to calculate the correct cookie domain
@ -156,6 +153,7 @@ else:
# Fallback to the hostname if parsing fails
SESSION_COOKIE_DOMAIN = hostname
# Static files (CSS, JavaScript, Images)
# https://docs.djangoproject.com/en/1.7/howto/static-files/