From 5aef1eb8bdf8ee0e81cadb041a518d6f1e31c13c Mon Sep 17 00:00:00 2001
From: Sean Morley <zipsm15@gmail.com>
Date: Sun, 11 Aug 2024 13:34:32 -0400
Subject: [PATCH] Fix collection link

---
 .../src/lib/components/AdventureLink.svelte   | 24 +++++++++++--------
 .../routes/adventures/[id]/+page.server.ts    |  4 +---
 .../src/routes/adventures/[id]/+page.svelte   |  2 +-
 3 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/frontend/src/lib/components/AdventureLink.svelte b/frontend/src/lib/components/AdventureLink.svelte
index 71486ee..b1bb85f 100644
--- a/frontend/src/lib/components/AdventureLink.svelte
+++ b/frontend/src/lib/components/AdventureLink.svelte
@@ -10,6 +10,8 @@
 
 	let adventures: Adventure[] = [];
 
+	let isLoading: boolean = true;
+
 	export let user: User | null;
 
 	onMount(async () => {
@@ -17,19 +19,16 @@
 		if (modal) {
 			modal.showModal();
 		}
-		let formData = new FormData();
-		formData.append('include_collections', 'false');
-		let res = await fetch(`/adventures?/all`, {
-			method: 'POST',
-			body: formData
+		let res = await fetch(`/api/adventures/all/?include_collections=false`, {
+			method: 'GET'
 		});
 
-		const result: ActionResult = deserialize(await res.text());
-		console.log(result);
+		const newAdventures = await res.json();
 
-		if (result.type === 'success' && result.data) {
-			adventures = result.data.adventures as Adventure[];
+		if (res.ok && adventures) {
+			adventures = newAdventures;
 		}
+		isLoading = false;
 	});
 
 	function close() {
@@ -53,11 +52,16 @@
 	<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
 	<div class="modal-box w-11/12 max-w-5xl" role="dialog" on:keydown={handleKeydown} tabindex="0">
 		<h1 class="text-center font-bold text-4xl mb-6">My Adventures</h1>
+		{#if isLoading}
+			<div class="flex justify-center items-center w-full mt-16">
+				<span class="loading loading-spinner w-24 h-24"></span>
+			</div>
+		{/if}
 		<div class="flex flex-wrap gap-4 mr-4 justify-center content-center">
 			{#each adventures as adventure}
 				<AdventureCard user={user ?? null} type="link" {adventure} on:link={add} />
 			{/each}
-			{#if adventures.length === 0}
+			{#if adventures.length === 0 && !isLoading}
 				<p class="text-center text-lg">
 					No adventures found that can be linked to this collection.
 				</p>
diff --git a/frontend/src/routes/adventures/[id]/+page.server.ts b/frontend/src/routes/adventures/[id]/+page.server.ts
index 8c0a4bc..aa253fb 100644
--- a/frontend/src/routes/adventures/[id]/+page.server.ts
+++ b/frontend/src/routes/adventures/[id]/+page.server.ts
@@ -146,15 +146,13 @@ export const actions: Actions = {
 			};
 		}
 
-		let trip_id_number: number = parseInt(trip_id as string);
-
 		let res = await fetch(`${serverEndpoint}/api/adventures/${event.params.id}/`, {
 			method: 'PATCH',
 			headers: {
 				Cookie: `${event.cookies.get('auth')}`,
 				'Content-Type': 'application/json'
 			},
-			body: JSON.stringify({ collection: trip_id_number })
+			body: JSON.stringify({ collection: trip_id })
 		});
 		let res2 = await res.json();
 		console.log(res2);
diff --git a/frontend/src/routes/adventures/[id]/+page.svelte b/frontend/src/routes/adventures/[id]/+page.svelte
index 240a3c0..0640383 100644
--- a/frontend/src/routes/adventures/[id]/+page.svelte
+++ b/frontend/src/routes/adventures/[id]/+page.svelte
@@ -171,7 +171,7 @@
 									<span class="text-sm text-muted-foreground">{adventure.location}</span>
 								</div>
 							{/if}
-							{#if adventure.activity_types}
+							{#if adventure.activity_types && adventure.activity_types?.length > 0}
 								<div class="flex items-center gap-2">
 									<svg
 										xmlns="http://www.w3.org/2000/svg"