1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00

Fix holding avg cost calculation

This commit is contained in:
Zach Gollwitzer 2024-12-12 15:11:06 -05:00
parent 800eb4c146
commit 027c18297b
3 changed files with 15 additions and 3 deletions

View file

@ -26,8 +26,12 @@ class Account::Holding < ApplicationRecord
# Basic approximation of cost-basis
def avg_cost
avg_cost = account.holdings.for(security).where(currency: currency).where("date <= ?", date).average(:price)
Money.new(avg_cost, currency)
avg_cost = account.entries.account_trades
.joins("INNER JOIN account_trades ON account_trades.id = account_entries.entryable_id")
.where("account_trades.security_id = ? AND account_trades.qty > 0 AND account_entries.date <= ?", security.id, date)
.average(:price)
Money.new(avg_cost || price, currency)
end
def trend

View file

@ -36,7 +36,6 @@
step: currency.step,
data: {
"money-field-target": "amount",
action: "change->money-field#handleAmountChange",
"auto-submit-form-target": ("auto" if options[:auto_submit])
}.compact,
required: options[:required] %>