From 0490fda46583e4e6dc3c65b89b5bcd9a638d803c Mon Sep 17 00:00:00 2001 From: Mattia Date: Wed, 14 Feb 2024 12:55:23 +0000 Subject: [PATCH] Improve active class assignment in sidebar links (#450) * Fix active class assignment in sidebar links * Revert "Fix active class assignment in sidebar links" This reverts commit 55924f32db9f5a0c0948d19b3af79d729feb6ef7. * Update sidebar_link_to helper to correctly assign active class for nested routes --------- Co-authored-by: Zach Gollwitzer --- app/helpers/application_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 3e01dea3..1090869d 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -34,7 +34,7 @@ module ApplicationHelper hover_class_names = [ "hover:bg-white", "hover:border-alpha-black-50", "hover:text-gray-900", "hover:shadow-xs" ] current_page_class_names = [ "bg-white", "border-alpha-black-50", "text-gray-900", "shadow-xs" ] - link_class_names = if current_page?(path) + link_class_names = if current_page?(path) || (request.path.start_with?(path) && path != "/") base_class_names.delete("border-transparent") base_class_names + hover_class_names + current_page_class_names else