Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00
Code Issues Releases Activity Actions

Refactor: Allow other import files (#1099)

Browse source 
* Rename stimulus controller

* feature: rename raw_csv_str to raw_file_str
This commit is contained in:
Pedro Carmona 2024-08-19 14:25:07 +01:00 • committed by GitHub
parent e6528bafec
commit 0c1ff00c1e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 71 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

20
app/models/import.rb
View file

@ -1,7 +1,7 @@
class Import < ApplicationRecord
belongs_to :account
validate :raw_csv_must_be_parsable
validate :raw_file_must_be_parsable
validates :col_sep, inclusion: { in: Csv::COL_SEP_LIST }
before_save :initialize_csv, if: :should_initialize_csv?
@ -19,7 +19,7 @@ class Import < ApplicationRecord
end
def loaded?
raw_csv_str.present?
raw_file_str.present?
end
def configured?
@ -88,16 +88,16 @@ class Import < ApplicationRecord
end
def get_raw_csv
return nil if raw_csv_str.nil?
Import::Csv.new(raw_csv_str, col_sep:)
return nil if raw_file_str.nil?
Import::Csv.new(raw_file_str, col_sep:)
end
def should_initialize_csv?
raw_csv_str_changed? || column_mappings_changed?
raw_file_str_changed? || column_mappings_changed?
end
def initialize_csv
generated_csv = generate_normalized_csv(raw_csv_str)
generated_csv = generate_normalized_csv(raw_file_str)
self.normalized_csv_str = generated_csv.table.to_s
end
@ -175,12 +175,12 @@ class Import < ApplicationRecord
end
end
def raw_csv_must_be_parsable
def raw_file_must_be_parsable
begin
CSV.parse(raw_csv_str || "", col_sep:)
CSV.parse(raw_file_str || "", col_sep:)
rescue CSV::MalformedCSVError
# i18n-tasks-use t('activerecord.errors.models.import.attributes.raw_csv_str.invalid_csv_format')
errors.add(:raw_csv_str, :invalid_csv_format)
# i18n-tasks-use t('activerecord.errors.models.import.attributes.raw_file_str.invalid_csv_format')
errors.add(:raw_file_str, :invalid_csv_format)
end
end
end

4
app/models/import/csv.rb
View file

@ -11,8 +11,8 @@ class Import::Csv
)
end
def self.create_with_field_mappings(raw_csv_str, fields, field_mappings, col_sep = DEFAULT_COL_SEP)
raw_csv = self.parse_csv(raw_csv_str, col_sep:)
def self.create_with_field_mappings(raw_file_str, fields, field_mappings, col_sep = DEFAULT_COL_SEP)
raw_csv = self.parse_csv(raw_file_str, col_sep:)
generated_csv_str = CSV.generate headers: fields.map { |f| f.key }, write_headers: true, col_sep: do |csv|
raw_csv.each do |row|