Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-21 14:19:39 +02:00
Code Issues Releases Activity Actions

Change default valuation currency to that of the related account, not family (#728)

Browse source
This commit is contained in:
Jakub Kottnauer 2024-05-08 21:29:56 +02:00 • committed by GitHub
parent 9ede14d23b
commit 1108e45596
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/valuations_controller.rb
View file

@ -4,7 +4,7 @@ class ValuationsController < ApplicationController
@account = Current.family.accounts.find(params[:account_id]) @account = Current.family.accounts.find(params[:account_id])
# TODO: placeholder logic until we have a better abstraction for trends # TODO: placeholder logic until we have a better abstraction for trends
@valuation = @account.valuations.new(valuation_params.merge(currency: Current.family.currency)) @valuation = @account.valuations.new(valuation_params.merge(currency: @account.currency))
if @valuation.save if @valuation.save
@valuation.account.sync_later(@valuation.date) @valuation.account.sync_later(@valuation.date)

6
test/controllers/valuations_controller_test.rb
View file

@ -20,6 +20,12 @@ class ValuationsControllerTest < ActionDispatch::IntegrationTest
assert_redirected_to account_path(@valuation.account) assert_redirected_to account_path(@valuation.account)
end end
test "should create valuation with account's currency" do
foreign_account = accounts(:eur_checking)
post account_valuations_url(foreign_account), params: { valuation: { value: 1, date: Date.current, type: "Appraisal" } }
assert_equal foreign_account.currency, Valuation.order(created_at: :desc).first.currency
end
test "create should sync account with correct start date" do test "create should sync account with correct start date" do
date = Date.current - 1.day date = Date.current - 1.day