diff --git a/app/javascript/controllers/rule/conditions_controller.js b/app/javascript/controllers/rule/conditions_controller.js index c4717a5c..e2e08240 100644 --- a/app/javascript/controllers/rule/conditions_controller.js +++ b/app/javascript/controllers/rule/conditions_controller.js @@ -32,7 +32,7 @@ export default class extends Controller { this.element.remove(); } - // Update the prefixes of all siblings from the parent rules controller + // Update the prefixes of all conditions from the parent rules controller if (rulesEl) { const rulesController = this.application.getControllerForElementAndIdentifier(rulesEl, "rules"); if (rulesController && typeof rulesController.updateConditionPrefixes === "function") { diff --git a/app/views/rule/conditions/_condition.html.erb b/app/views/rule/conditions/_condition.html.erb index 5eae0fe7..60c38eab 100644 --- a/app/views/rule/conditions/_condition.html.erb +++ b/app/views/rule/conditions/_condition.html.erb @@ -1,14 +1,18 @@ -<%# locals: (form:) %> +<%# locals: (form:, show_prefix: true) %> <% condition = form.object %> <% rule = condition.rule %>
  • - <%# Show prefix on conditions, except the first one %> -
    - and -
    + <%# Conditionally render the prefix %> + <%# Condition groups pass in show_prefix: false for subconditions since the ANY/ALL selector makes that clear %> + <% if show_prefix %> +
    + and +
    + <% end %> +
    <%= form.hidden_field :_destroy, value: false, data: { rule__conditions_target: "destroyField" } %> diff --git a/app/views/rule/conditions/_condition_group.html.erb b/app/views/rule/conditions/_condition_group.html.erb index d691dacf..e04a09f7 100644 --- a/app/views/rule/conditions/_condition_group.html.erb +++ b/app/views/rule/conditions/_condition_group.html.erb @@ -29,13 +29,13 @@ <%# Sub-condition template, used by Stimulus controller to add new sub-conditions dynamically %>