Account namespace updates: part 5 (valuations) (#901)

* Move Valuation to Account namespace

* Move account history to controller

* Clean up valuation controller and views

* Translations and cleanup

* Remove unused scopes and methods

* Pass brakeman

test/models/account/transfer_test.rb

@@ -1,6 +1,6 @@
 require "test_helper"
 
-class TransferTest < ActiveSupport::TestCase
+class Account::TransferTest < ActiveSupport::TestCase
   setup do
     # Transfers can be posted on different dates
     @outflow = accounts(:checking).transactions.create! date: 1.day.ago.to_date, name: "Transfer to Savings", amount: 100, marked_as_transfer: true

test/models/account/valuation_test.rb

@@ -0,0 +1,39 @@
+require "test_helper"
+
+class Account::ValuationTest < ActiveSupport::TestCase
+  setup do
+    @valuation = account_valuations :savings_one
+    @family = families :dylan_family
+  end
+
+  test "one valuation per day" do
+    assert_equal 12.days.ago.to_date, account_valuations(:savings_one).date
+    invalid_valuation = Account::Valuation.new date: 12.days.ago.to_date, value: 20000
+    assert invalid_valuation.invalid?
+  end
+
+  test "triggers sync with correct start date when valuation is set to prior date" do
+    prior_date = @valuation.date - 1
+    @valuation.update! date: prior_date
+
+    @valuation.account.expects(:sync_later).with(prior_date)
+    @valuation.sync_account_later
+  end
+
+  test "triggers sync with correct start date when valuation is set to future date" do
+    prior_date = @valuation.date
+    @valuation.update! date: @valuation.date + 1
+
+    @valuation.account.expects(:sync_later).with(prior_date)
+    @valuation.sync_account_later
+  end
+
+  test "triggers sync with correct start date when valuation deleted" do
+    prior_valuation = account_valuations :savings_two # 25 days ago
+    current_valuation = account_valuations :savings_one # 12 days ago
+    current_valuation.destroy!
+
+    current_valuation.account.expects(:sync_later).with(prior_valuation.date)
+    current_valuation.sync_account_later
+  end
+end

test/models/account_test.rb

@@ -111,7 +111,7 @@ class AccountTest < ActiveSupport::TestCase
   end
 
   test "should destroy dependent valuations" do
-    assert_difference("Valuation.count", -@account.valuations.count) do
+    assert_difference("Account::Valuation.count", -@account.valuations.count) do
       @account.destroy
     end
   end

test/models/time_series/trend_test.rb

@@ -11,11 +11,13 @@ class TimeSeries::TrendTest < ActiveSupport::TestCase
   test "up" do
     trend = TimeSeries::Trend.new(current: 100, previous: 50)
     assert_equal "up", trend.direction
+    assert_equal "#10A861", trend.color
   end
 
   test "down" do
     trend = TimeSeries::Trend.new(current: 50, previous: 100)
     assert_equal "down", trend.direction
+    assert_equal "#F13636", trend.color
   end
 
   test "flat" do
@@ -25,6 +27,7 @@ class TimeSeries::TrendTest < ActiveSupport::TestCase
     assert_equal "flat", trend1.direction
     assert_equal "flat", trend2.direction
     assert_equal "flat", trend3.direction
+    assert_equal "#737373", trend1.color
   end
 
   test "infinitely up" do

test/models/valuation_test.rb

@@ -1,4 +0,0 @@
-require "test_helper"
-
-class ValuationTest < ActiveSupport::TestCase
-end