perf(transactions): add kind to Transaction model and remove expensive Transfer joins in aggregations (#2388)

* add kind to transaction model

* Basic transfer creator

* Fix method naming conflict

* Creator form pattern

* Remove stale methods

* Tweak migration

* Remove BaseQuery, write entire query in each class for clarity

* Query optimizations

* Remove unused exchange rate query lines

* Remove temporary cache-warming strategy

* Fix test

* Update transaction search

* Decouple transactions endpoint from IncomeStatement

* Clean up transactions controller

* Update cursor rules

* Cleanup comments, logic in search

* Fix totals logic on transactions view

* Fix pagination

* Optimize search totals query

* Default to last 30 days on transactions page if no filters

* Decouple transactions list from transfer details

* Revert transfer route

* Migration reset

* Bundle update

* Fix matching logic, tests

* Remove unused code

app/views/transactions/_summary.html.erb

@@ -2,7 +2,7 @@
 <div class="grid grid-cols-1 md:grid-cols-3 bg-container rounded-xl shadow-border-xs md:divide-x divide-y md:divide-y-0 divide-alpha-black-100 theme-dark:divide-alpha-white-200">
   <div class="p-4 space-y-2">
     <p class="text-sm text-secondary">Total transactions</p>
-    <p class="text-primary font-medium text-xl" id="total-transactions"><%= totals.transactions_count.round(0) %></p>
+    <p class="text-primary font-medium text-xl" id="total-transactions"><%= totals.count.round(0) %></p>
   </div>
   <div class="p-4 space-y-2">
     <p class="text-sm text-secondary">Income</p>

app/views/transactions/_transaction.html.erb

@@ -10,7 +10,7 @@
 
       <div class="pr-4 lg:pr-10 flex items-center gap-3 lg:gap-4 col-span-8 lg:col-span-6">
         <%= check_box_tag dom_id(entry, "selection"),
-            disabled: transaction.transfer?,
+            disabled: transaction.transfer.present?,
             class: "checkbox checkbox--light",
             data: {
               id: entry.id,
@@ -36,15 +36,27 @@
             <div class="truncate">
               <div class="space-y-0.5">
                 <div class="flex items-center gap-1">
-                  <%= link_to(
-                        transaction.transfer? ? transaction.transfer.name : entry.name,
-                        transaction.transfer? ? transfer_path(transaction.transfer) : entry_path(entry),
-                        data: {
-                          turbo_frame: "drawer",
-                          turbo_prefetch: false
-                        },
-                        class: "hover:underline"
-                      ) %>
+                  <% if transaction.transfer? %>
+                    <%= link_to(
+                          entry.name,
+                          transaction.transfer.present? ? transfer_path(transaction.transfer) : entry_path(entry),
+                          data: {
+                            turbo_frame: "drawer",
+                            turbo_prefetch: false
+                          },
+                          class: "hover:underline"
+                        ) %>
+                  <% else %>
+                    <%= link_to(
+                          entry.name,
+                          entry_path(entry),
+                          data: {
+                            turbo_frame: "drawer",
+                            turbo_prefetch: false
+                          },
+                          class: "hover:underline"
+                        ) %>
+                  <% end %>
 
                   <% if entry.excluded %>
                     <span class="text-orange-500" title="One-time <%= entry.amount.negative? ? "income" : "expense" %> (excluded from averages)">
@@ -52,16 +64,16 @@
                     </span>
                   <% end %>
 
-                  <% if transaction.transfer? %>
+                  <% if transaction.transfer.present? %>
                     <%= render "transactions/transfer_match", transaction: transaction %>
                   <% end %>
                 </div>
 
                 <div class="text-secondary text-xs font-normal hidden lg:block">
                   <% if transaction.transfer? %>
-                    <%= render "transfers/account_links",
-                        transfer: transaction.transfer,
-                        is_inflow: transaction.transfer_as_inflow.present? %>
+                    <span class="text-secondary">
+                      <%= transaction.loan_payment? ? "Loan Payment" : "Transfer" %> • <%= entry.account.name %>
+                    </span>
                   <% else %>
                     <%= link_to entry.account.name,
                         account_path(entry.account, tab: "transactions", focused_record_id: entry.id),
@@ -79,7 +91,7 @@
         <%= render "transactions/transaction_category", transaction: transaction %>
       </div>
 
-      <div class="col-span-4 lg:col-span-2 ml-auto text-right">
+      <div class="col-span-4 ml-auto text-right">
         <%= content_tag :p,
             transaction.transfer? && view_ctx == "global" ? "+/- #{format_money(entry.amount_money.abs)}" : format_money(-entry.amount_money),
             class: ["text-green-600": entry.amount.negative?] %>
@@ -89,7 +101,7 @@
         <% if balance_trend&.trend %>
           <%= tag.p format_money(balance_trend.trend.current),
                 class: "font-medium text-sm text-primary" %>
-        <% else %>
+        <% elsif view_ctx != "global" %>
           <%= tag.p "--", class: "font-medium text-sm text-gray-400" %>
         <% end %>
       </div>

app/views/transactions/index.html.erb

@@ -43,7 +43,7 @@
     </div>
   </header>
 
-  <%= render "summary", totals: @totals %>
+  <%= render "summary", totals: @search.totals %>
 
   <div id="transactions"
        data-controller="bulk-select"