Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00
Code Issues Releases Activity Actions

perf(transactions): add kind to Transaction model and remove expensive Transfer joins in aggregations (#2388)

Browse source 
* add kind to transaction model

* Basic transfer creator

* Fix method naming conflict

* Creator form pattern

* Remove stale methods

* Tweak migration

* Remove BaseQuery, write entire query in each class for clarity

* Query optimizations

* Remove unused exchange rate query lines

* Remove temporary cache-warming strategy

* Fix test

* Update transaction search

* Decouple transactions endpoint from IncomeStatement

* Clean up transactions controller

* Update cursor rules

* Cleanup comments, logic in search

* Fix totals logic on transactions view

* Fix pagination

* Optimize search totals query

* Default to last 30 days on transactions page if no filters

* Decouple transactions list from transfer details

* Revert transfer route

* Migration reset

* Bundle update

* Fix matching logic, tests

* Remove unused code
This commit is contained in:
Zach Gollwitzer 2025-06-20 13:31:58 -04:00 • committed by GitHub
parent 7aca5a2277
commit 1aae00f586
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
49 changed files with 1749 additions and 705 deletions
Download patch file Download diff file Expand all files Collapse all files

32
db/migrate/20250616183654_add_kind_to_transactions.rb Normal file
View file

@ -0,0 +1,32 @@
class AddKindToTransactions < ActiveRecord::Migration[7.2]
def change
add_column :transactions, :kind, :string, null: false, default: "standard"
add_index :transactions, :kind
reversible do |dir|
dir.up do
# Update transaction kinds based on transfer relationships
execute <<~SQL
UPDATE transactions
SET kind = CASE
WHEN destination_accounts.accountable_type = 'Loan' AND entries.amount > 0 THEN 'loan_payment'
WHEN destination_accounts.accountable_type = 'CreditCard' AND entries.amount > 0 THEN 'cc_payment'
ELSE 'funds_movement'
END
FROM transfers t
JOIN entries ON (
entries.entryable_id = t.inflow_transaction_id OR
entries.entryable_id = t.outflow_transaction_id
)
LEFT JOIN entries inflow_entries ON (
inflow_entries.entryable_id = t.inflow_transaction_id
AND inflow_entries.entryable_type = 'Transaction'
)
LEFT JOIN accounts destination_accounts ON destination_accounts.id = inflow_entries.account_id
WHERE transactions.id = entries.entryable_id
AND entries.entryable_type = 'Transaction'
SQL
end
end
end
end