Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00
Code Issues Releases Activity Actions

Improved UI warning states for holdings with missing data (#1098)

Browse source 
* Fix security price issue flow

* Fix tooltip positioning and add tooltip for missing holding data

* Fix tooltip controller error with stale arrow target

* Lint fixes
This commit is contained in:
Zach Gollwitzer 2024-08-16 16:08:27 -04:00 • committed by GitHub
parent 4527482aa2
commit 1b6ce6af45
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 141 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/models/issue/prices_missing.rb
View file

@ -1,6 +1,8 @@
class Issue::PricesMissing < Issue
store_accessor :data, :missing_prices
after_initialize :initialize_missing_prices
validates :missing_prices, presence: true
def append_missing_price(ticker, date)
@ -10,7 +12,10 @@ class Issue::PricesMissing < Issue
def stale?
stale = true
missing_prices.each do |ticker, dates|
next unless issuable.owns_ticker?(ticker)
oldest_date = dates.min
expected_price_count = (oldest_date..Date.current).count
prices = Security::Price.find_prices(ticker: ticker, start_date: oldest_date)
@ -19,4 +24,10 @@ class Issue::PricesMissing < Issue
stale
end
private
def initialize_missing_prices
self.missing_prices ||= {}
end
end