User Onboarding + Bug Fixes (#1352)

* Bump min supported date to 20 years

* Add basic onboarding

* User onboarding

* Complete onboarding flow

* Cleanup, add user profile update test

test/controllers/sessions_controller_test.rb

@@ -28,7 +28,7 @@ class SessionsControllerTest < ActionDispatch::IntegrationTest
     sign_in @user
 
     delete session_url(@user.sessions.order(:created_at).last)
-    assert_redirected_to root_url
+    assert_redirected_to new_session_path
     assert_equal "You have signed out successfully.", flash[:notice]
   end
 end

test/controllers/settings/profiles_controller_test.rb

@@ -9,35 +9,4 @@ class Settings::ProfilesControllerTest < ActionDispatch::IntegrationTest
     get settings_profile_url
     assert_response :success
   end
-
-  test "member can deactivate their account" do
-    sign_in @member = users(:family_member)
-    delete settings_profile_url
-
-    assert_redirected_to root_url
-
-    assert_not User.find(@member.id).active?
-    assert_enqueued_with(job: UserPurgeJob, args: [ @member ])
-  end
-
-  test "admin prevented from deactivating when other users are present" do
-    sign_in @admin = users(:family_admin)
-    delete settings_profile_url
-
-    assert_redirected_to settings_profile_url
-    assert_equal "Admin cannot delete account while other users are present. Please delete all members first.", flash[:alert]
-    assert_no_enqueued_jobs only: UserPurgeJob
-    assert User.find(@admin.id).active?
-  end
-
-  test "admin can deactivate their account when they are the last user in the family" do
-    sign_in @admin = users(:family_admin)
-    users(:family_member).destroy
-
-    delete settings_profile_url
-
-    assert_redirected_to root_url
-    assert_not User.find(@admin.id).active?
-    assert_enqueued_with(job: UserPurgeJob, args: [ @admin ])
-  end
 end

test/controllers/users_controller_test.rb

@@ -0,0 +1,64 @@
+require "test_helper"
+
+class UsersControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in @user = users(:family_admin)
+  end
+
+  test "can supply custom redirect after update" do
+    patch user_url(@user), params: { user: { redirect_to: "home" } }
+    assert_redirected_to root_url
+  end
+
+  test "can update user profile" do
+    patch user_url(@user), params: {
+      user: {
+        first_name: "John",
+        last_name: "Doe",
+        onboarded_at: Time.current,
+        profile_image: file_fixture_upload("profile_image.png", "image/png", :binary),
+        family_attributes: {
+          name: "New Family Name",
+          country: "US",
+          date_format: "%m/%d/%Y",
+          currency: "USD",
+          locale: "en"
+        }
+      }
+    }
+
+    assert_redirected_to settings_profile_url
+    assert_equal "Your profile has been updated.", flash[:notice]
+  end
+
+  test "member can deactivate their account" do
+    sign_in @member = users(:family_member)
+    delete user_url(@member)
+
+    assert_redirected_to root_url
+
+    assert_not User.find(@member.id).active?
+    assert_enqueued_with(job: UserPurgeJob, args: [ @member ])
+  end
+
+  test "admin prevented from deactivating when other users are present" do
+    sign_in @admin = users(:family_admin)
+    delete user_url(users(:family_member))
+
+    assert_redirected_to settings_profile_url
+    assert_equal "Admin cannot delete account while other users are present. Please delete all members first.", flash[:alert]
+    assert_no_enqueued_jobs only: UserPurgeJob
+    assert User.find(@admin.id).active?
+  end
+
+  test "admin can deactivate their account when they are the last user in the family" do
+    sign_in @admin = users(:family_admin)
+    users(:family_member).destroy
+
+    delete user_url(@admin)
+
+    assert_redirected_to root_url
+    assert_not User.find(@admin.id).active?
+    assert_enqueued_with(job: UserPurgeJob, args: [ @admin ])
+  end
+end