Improve dark mode styles across multiple pages (#2125)

* fix: improve dark mode readability across the app

* fix: improve dark mode support for asset percentage text

* fix: apply suggested patch for theme-related improvements

* chore: apply PR feedback – remove dark:, align with design tokens, update form builder

* chore: revert background token and restore original style for visual consistency

* chore: remove unnecessary class attributes from form fields using builder

* refactor: move number_field and date_field into metaprogramming block

* refactor: replace bg-divider-adaptive divs with <hr> and border-secondary

* fix: apply requested changes and linting fixes

app/views/budgets/_actuals_summary.html.erb

@@ -1,7 +1,7 @@
 <%# locals: (budget:) %>
 
 <div>
-  <div class="p-4 border-b border-gray-100">
+  <div class="p-4 border-b border-secondary">
     <h3 class="text-sm text-secondary mb-2">Income</h3>
 
     <span class="inline-block mb-2 text-xl font-medium text-primary">

app/views/budgets/_budget_nav.html.erb

@@ -16,7 +16,7 @@
                   step[:is_complete] ? "text-green-600" : "text-secondary"
                 end %>
       <% step_class = if is_current
-                  "bg-primary text-white"
+                  "bg-primary text-primary"
                 else
                   step[:is_complete] ? "bg-green-600/10 border-alpha-black-25" : "bg-container-inset"
                 end %>
@@ -31,7 +31,7 @@
         </div>
       <% end %>
 
-      <div class="h-px bg-alpha-black-200 w-12 group-last:hidden"></div>
+      <hr class="border border-secondary w-12 group-last:hidden">
     </li>
   <% end %>
 </ul>

app/views/budgets/_budgeted_summary.html.erb

@@ -1,7 +1,7 @@
 <%# locals: (budget:) %>
 
 <div>
-  <div class="p-4 border-b border-gray-100">
+  <div class="p-4 border-b border-secondary">
     <h3 class="text-sm text-secondary mb-2">Expected income</h3>
 
     <span class="inline-block mb-2 text-xl font-medium text-primary">