add fix etl and test Teller sandbox

.env.example

@@ -57,4 +57,4 @@ NX_POSTMARK_API_TOKEN=
 ########################################################################
 NX_PLAID_SECRET=
 NX_FINICITY_APP_KEY=
-NX_FINICITY_PARTNER_SECRET=
+NX_FINICITY_PARTNER_SECRET=

apps/workers/src/main.ts

@@ -140,7 +140,7 @@ syncInstitutionQueue.add(
     'sync-teller-institutions',
     {},
     {
-        repeat: { cron: '* */24 * * *' }, // Run every 24 hours
+        repeat: { cron: '0 0 */1 * *' }, // Run every 24 hours
     }
 )
 

libs/client/shared/src/api/useTellerApi.ts

@@ -6,6 +6,7 @@ import type { SharedType } from '@maybe-finance/shared'
 import { invalidateAccountQueries } from '../utils'
 import type { AxiosInstance } from 'axios'
 import type { TellerTypes } from '@maybe-finance/teller-api'
+import { useAccountConnectionApi } from './useAccountConnectionApi'
 
 type TellerInstitution = {
     name: string
@@ -30,6 +31,9 @@ export function useTellerApi() {
     const { axios } = useAxiosWithAuth()
     const api = useMemo(() => TellerApi(axios), [axios])
 
+    const { useSyncConnection } = useAccountConnectionApi()
+    const syncConnection = useSyncConnection()
+
     const addConnectionToState = (connection: SharedType.AccountConnection) => {
         const accountsData = queryClient.getQueryData<SharedType.AccountsResponse>(['accounts'])
         if (!accountsData)
@@ -50,6 +54,7 @@ export function useTellerApi() {
         useMutation(api.handleEnrollment, {
             onSuccess: (_connection) => {
                 addConnectionToState(_connection)
+                syncConnection.mutate(_connection.id)
                 toast.success(`Account connection added!`)
             },
             onSettled: () => {

libs/client/shared/src/hooks/useTeller.ts

@@ -58,7 +58,7 @@ export const useTellerConnect = (options: TellerConnectOptions, logger: Logger)
             {
                 ...options,
                 onSuccess: async (enrollment: TellerConnectEnrollment) => {
-                    logger.debug(`User enrolled successfully`, enrollment)
+                    logger.debug('User enrolled successfully')
                     try {
                         await handleEnrollment.mutateAsync({
                             institution: {

libs/server/features/src/providers/teller/teller.etl.ts

@@ -1,6 +1,6 @@
 import type { AccountConnection, PrismaClient } from '@prisma/client'
 import type { Logger } from 'winston'
-import { SharedUtil, AccountUtil, type SharedType } from '@maybe-finance/shared'
+import { SharedUtil, type SharedType } from '@maybe-finance/shared'
 import type { TellerApi, TellerTypes } from '@maybe-finance/teller-api'
 import { DbUtil, TellerUtil, type IETL, type ICryptoService } from '@maybe-finance/server/shared'
 import { Prisma } from '@prisma/client'
@@ -117,8 +117,6 @@ export class TellerETL implements IETL<Connection, TellerRawData, TellerData> {
         return [
             // upsert accounts
             ...accounts.map((tellerAccount) => {
-                const type = TellerUtil.getType(tellerAccount.type)
-                const classification = AccountUtil.getClassification(type)
                 return this.prisma.account.upsert({
                     where: {
                         accountConnectionId_tellerAccountId: {
@@ -132,12 +130,13 @@ export class TellerETL implements IETL<Connection, TellerRawData, TellerData> {
                         categoryProvider: TellerUtil.tellerTypesToCategory(tellerAccount.type),
                         subcategoryProvider: tellerAccount.subtype ?? 'other',
                         accountConnectionId: connection.id,
+                        userId: connection.userId,
                         tellerAccountId: tellerAccount.id,
                         name: tellerAccount.name,
                         tellerType: tellerAccount.type,
                         tellerSubtype: tellerAccount.subtype,
                         mask: tellerAccount.last_four,
-                        ...TellerUtil.getAccountBalanceData(tellerAccount, classification),
+                        ...TellerUtil.getAccountBalanceData(tellerAccount),
                     },
                     update: {
                         type: TellerUtil.getType(tellerAccount.type),
@@ -145,7 +144,7 @@ export class TellerETL implements IETL<Connection, TellerRawData, TellerData> {
                         subcategoryProvider: tellerAccount.subtype ?? 'other',
                         tellerType: tellerAccount.type,
                         tellerSubtype: tellerAccount.subtype,
-                        ..._.omit(TellerUtil.getAccountBalanceData(tellerAccount, classification), [
+                        ..._.omit(TellerUtil.getAccountBalanceData(tellerAccount), [
                             'currentBalanceStrategy',
                             'availableBalanceStrategy',
                         ]),
@@ -226,13 +225,13 @@ export class TellerETL implements IETL<Connection, TellerRawData, TellerData> {
                                 } AND teller_account_id = ${account_id.toString()}),
                                 ${id},
                                 ${date}::date,
-                                ${[description].filter(Boolean).join(' ')},
+                                ${description},
                                 ${DbUtil.toDecimal(-amount)},
                                 ${status === 'pending'},
                                 ${'USD'},
                                 ${details.counterparty.name ?? ''},
                                 ${type},
-                                ${details.category ?? ''},
+                                ${details.category ?? ''}
                             )`
                         })
                     )}

libs/server/features/src/providers/teller/teller.service.ts

@@ -45,6 +45,7 @@ export class TellerService implements IAccountConnectionProvider, IInstitutionPr
                     where: { id: connection.id },
                     data: {
                         status: 'OK',
+                        syncStatus: 'IDLE',
                     },
                 })
                 break
@@ -157,21 +158,6 @@ export class TellerService implements IAccountConnectionProvider, IInstitutionPr
             throw new Error('USD_ONLY')
         }
 
-        // Create account connection on exchange; accounts + txns will sync later with webhook
-        const [accountConnection] = await this.prisma.$transaction([
-            this.prisma.accountConnection.create({
-                data: {
-                    name: enrollment.enrollment.institution.name,
-                    type: 'teller' as SharedType.AccountConnectionType,
-                    tellerEnrollmentId: enrollment.enrollment.id,
-                    tellerInstitutionId: institution.id,
-                    tellerAccessToken: this.crypto.encrypt(enrollment.accessToken),
-                    userId,
-                    syncStatus: 'PENDING',
-                },
-            }),
-        ])
-
         await this.prisma.user.update({
             where: { id: userId },
             data: {
@@ -179,6 +165,28 @@ export class TellerService implements IAccountConnectionProvider, IInstitutionPr
             },
         })
 
+        const accountConnection = await this.prisma.accountConnection.create({
+            data: {
+                name: enrollment.enrollment.institution.name,
+                type: 'teller' as SharedType.AccountConnectionType,
+                tellerEnrollmentId: enrollment.enrollment.id,
+                tellerInstitutionId: institution.id,
+                tellerAccessToken: this.crypto.encrypt(enrollment.accessToken),
+                userId,
+                syncStatus: 'PENDING',
+            },
+        })
+
+        await this.sync(accountConnection, { type: 'teller', initialSync: true })
+
+        await this.prisma.accountConnection.update({
+            where: { id: accountConnection.id },
+            data: {
+                status: 'OK',
+                syncStatus: 'IDLE',
+            },
+        })
+
         return accountConnection
     }
 }

libs/server/shared/src/utils/teller-utils.ts

@@ -1,10 +1,4 @@
-import {
+import { Prisma, AccountCategory, AccountType, type Account } from '@prisma/client'
-    Prisma,
-    AccountCategory,
-    AccountType,
-    type AccountClassification,
-    type Account,
-} from '@prisma/client'
 import type { TellerTypes } from '@maybe-finance/teller-api'
 import { Duration } from 'luxon'
 
@@ -13,10 +7,10 @@ import { Duration } from 'luxon'
  */
 export const TELLER_WINDOW_MAX = Duration.fromObject({ years: 1 })
 
-export function getAccountBalanceData(
+export function getAccountBalanceData({
-    { balances, currency }: Pick<TellerTypes.AccountWithBalances, 'balances' | 'currency'>,
+    balance,
-    classification: AccountClassification
+    currency,
-): Pick<
+}: Pick<TellerTypes.AccountWithBalances, 'balance' | 'currency'>): Pick<
     Account,
     | 'currentBalanceProvider'
     | 'currentBalanceStrategy'
@@ -24,16 +18,11 @@ export function getAccountBalanceData(
     | 'availableBalanceStrategy'
     | 'currencyCode'
 > {
-    // Flip balance values to positive for liabilities
-    const sign = classification === 'liability' ? -1 : 1
-
     return {
-        currentBalanceProvider: new Prisma.Decimal(
+        currentBalanceProvider: new Prisma.Decimal(balance.ledger ? Number(balance.ledger) : 0),
-            balances.ledger ? sign * Number(balances.ledger) : 0
-        ),
         currentBalanceStrategy: 'current',
         availableBalanceProvider: new Prisma.Decimal(
-            balances.available ? sign * Number(balances.available) : 0
+            balance.available ? Number(balance.available) : 0
         ),
         availableBalanceStrategy: 'available',
         currencyCode: currency,

libs/teller-api/src/types/accounts.ts

@@ -50,7 +50,7 @@ interface CreditAccount extends BaseAccount {
 export type Account = DepositoryAccount | CreditAccount
 
 export type AccountWithBalances = Account & {
-    balances: AccountBalance
+    balance: AccountBalance
 }
 
 export type GetAccountsResponse = Account[]