Move categories to top-level namespace (#894)

test/models/category_test.rb

@@ -1,50 +1,50 @@
 require "test_helper"
 
-class Transaction::CategoryTest < ActiveSupport::TestCase
+class CategoryTest < ActiveSupport::TestCase
   def setup
     @family = families(:dylan_family)
   end
 
   test "create_default_categories should generate categories if none exist" do
     @family.accounts.destroy_all
-    @family.transaction_categories.destroy_all
-    assert_difference "Transaction::Category.count", Transaction::Category::DEFAULT_CATEGORIES.size do
-      Transaction::Category.create_default_categories(@family)
+    @family.categories.destroy_all
+    assert_difference "Category.count", Category::DEFAULT_CATEGORIES.size do
+      Category.create_default_categories(@family)
     end
   end
 
   test "create_default_categories should raise when there are existing categories" do
     assert_raises(ArgumentError) do
-      Transaction::Category.create_default_categories(@family)
+      Category.create_default_categories(@family)
     end
   end
 
   test "updating name should clear the internal_category field" do
-    category = Transaction::Category.take
+    category = Category.take
     assert_changes "category.reload.internal_category", to: nil do
       category.update_attribute(:name, "new name")
     end
   end
 
   test "updating other field than name should not clear the internal_category field" do
-    category = Transaction::Category.take
+    category = Category.take
     assert_no_changes "category.reload.internal_category" do
       category.update_attribute(:color, "#000")
     end
   end
 
   test "replacing and destroying" do
-    transctions = transaction_categories(:food_and_drink).transactions.to_a
+    transctions = categories(:food_and_drink).transactions.to_a
 
-    transaction_categories(:food_and_drink).replace_and_destroy!(transaction_categories(:income))
+    categories(:food_and_drink).replace_and_destroy!(categories(:income))
 
-    assert_equal transaction_categories(:income), transactions.map { |t| t.reload.category }.uniq.first
+    assert_equal categories(:income), transactions.map { |t| t.reload.category }.uniq.first
   end
 
   test "replacing with nil should nullify the category" do
-    transactions = transaction_categories(:food_and_drink).transactions.to_a
+    transactions = categories(:food_and_drink).transactions.to_a
 
-    transaction_categories(:food_and_drink).replace_and_destroy!(nil)
+    categories(:food_and_drink).replace_and_destroy!(nil)
 
     assert_nil transactions.map { |t| t.reload.category }.uniq.first
   end

test/models/family_test.rb

@@ -33,7 +33,7 @@ class FamilyTest < ActiveSupport::TestCase
   end
 
   test "should destroy dependent transaction categories" do
-    assert_difference("Transaction::Category.count", -@family.transaction_categories.count) do
+    assert_difference("Category.count", -@family.categories.count) do
       @family.destroy
     end
   end

test/models/import_test.rb

@@ -46,7 +46,7 @@ class ImportTest < ActiveSupport::TestCase
     # "Shopping" is a new category, but should only be created 1x during import
     assert_difference \
       -> { Transaction.count } => 4,
-      -> { Transaction::Category.count } => 1,
+      -> { Category.count } => 1,
       -> { Tagging.count } => 4,
       -> { Tag.count } => 2 do
       @loaded_import.publish
@@ -59,7 +59,7 @@ class ImportTest < ActiveSupport::TestCase
 
   test "publishes a valid import with missing data" do
     @empty_import.update! raw_csv_str: valid_csv_with_missing_data
-    assert_difference -> { Transaction::Category.count } => 1, -> { Transaction.count } => 2 do
+    assert_difference -> { Category.count } => 1, -> { Transaction.count } => 2 do
       @empty_import.publish
     end