Fix registration fails silently when there are errors (#1455)

* Fix registration fails silently with long passwords

* Add maxlength

app/controllers/registrations_controller.rb

@@ -28,7 +28,7 @@ class RegistrationsController < ApplicationController
       @session = create_session_for(@user)
       redirect_to root_path, notice: t(".success")
     else
-      render :new, status: :unprocessable_entity
+      render :new, status: :unprocessable_entity, alert: t(".failure")
     end
   end
 

app/views/registrations/new.html.erb

@@ -17,6 +17,13 @@
   </div>
 <% end %>
 
+<% if @user.errors.present? %>
+  <div class="text-red-600 flex items-center gap-2">
+    <%= lucide_icon "circle-alert", class: "w-5 h-5" %>
+    <p class="text-sm"><%= @user.errors.full_messages.to_sentence %></p>
+  </div>
+<% end %>
+
 <%= styled_form_with model: @user, url: registration_path, class: "space-y-4" do |form| %>
   <%= form.email_field :email,
       autofocus: false,
@@ -25,7 +32,7 @@
       placeholder: "you@example.com",
       label: true,
       disabled: @invitation.present? %>
-  <%= form.password_field :password, autocomplete: "new-password", required: "required", label: true %>
+  <%= form.password_field :password, autocomplete: "new-password", required: "required", label: true, maxlength: 72 %>
   <%= form.password_field :password_confirmation, autocomplete: "new-password", required: "required", label: true %>
   <% if invite_code_required? && !@invitation %>
     <%= form.text_field :invite_code, required: "required", label: true, value: params[:invite] %>

config/locales/views/registrations/en.yml

@@ -11,6 +11,7 @@ en:
     create:
       invalid_invite_code: Invalid invite code, please try again.
       success: You have signed up successfully.
+      failure: There was a problem signing up.
     new:
       invitation_message: "%{inviter} has invited you to join as a %{role}"
       join_family_title: Join %{family}