Transaction rules engine V1 (#1900)

* Domain model sketch

* Scaffold out rules domain

* Migrations

* Remove existing data enrichment for clean slate

* Sketch out business logic and basic tests

* Simplify rule scope building and action executions

* Get generator working again

* Basic implementation + tests

* Remove manual merchant management (rules will replace)

* Revert "Remove manual merchant management (rules will replace)"

This reverts commit 83dcbd9ff0.

* Family and Provider merchants model

* Fix brakeman warnings

* Fix notification loader

* Update notification position

* Add Rule action and condition registries

* Rule form with compound conditions and tests

* Split out notification types, add CTA type

* Rules form builder and Stimulus controller

* Clean up rule registry domain

* Clean up rules stimulus controller

* CTA message for rule when user changes transaction category

* Fix tests

* Lint updates

* Centralize notifications in Notifiable concern

* Implement category rule prompts with auto backoff and option to disable

* Fix layout bug caused by merge conflict

* Initialize rule with correct action for category CTA

* Add rule deletions, get rules working

* Complete dynamic rule form, split Stimulus controllers by resource

* Fix failing tests

* Change test password to avoid chromium conflicts

* Update integration tests

* Centralize all test password references

* Add re-apply rule action

* Rule confirm modal

* Run migrations

* Trigger rule notification after inline category updates

* Clean up rule styles

* Basic attribute locking for rules

* Apply attribute locks on user edits

* Log data enrichments, only apply rules to unlocked attributes

* Fix merge errors

* Additional merge conflict fixes

* Form UI improvements, ignore attribute locks on manual rule application

* Batch AI auto-categorization of transactions

* Auto merchant detection, ai enrichment in batches

* Fix Plaid merchant assignments

* Plaid category matching

* Cleanup 1

* Test cleanup

* Remove stale route

* Fix desktop chat UI issues

* Fix mobile nav styling issues

app/javascript/controllers/modal_controller.js

@@ -22,7 +22,7 @@ export default class extends Controller {
     this.element.close();
 
     if (this.reloadOnCloseValue) {
-      window.location.reload();
+      Turbo.visit(window.location.href);
     }
   }
 }

app/javascript/controllers/rule/actions_controller.js

@@ -0,0 +1,55 @@
+import { Controller } from "@hotwired/stimulus";
+
+// Connects to data-controller="rule--actions"
+export default class extends Controller {
+  static values = { actionExecutors: Array };
+  static targets = ["destroyField", "actionValue"];
+
+  remove(e) {
+    if (e.params.destroy) {
+      this.destroyFieldTarget.value = true;
+    } else {
+      this.element.remove();
+    }
+  }
+
+  handleActionTypeChange(e) {
+    const actionExecutor = this.actionExecutorsValue.find(
+      (executor) => executor.key === e.target.value,
+    );
+
+    if (actionExecutor.type === "select") {
+      this.#updateValueSelectFor(actionExecutor);
+      this.#showAndEnableValueSelect();
+    } else {
+      this.#hideAndDisableValueSelect();
+    }
+  }
+
+  get valueSelectEl() {
+    return this.actionValueTarget.querySelector("select");
+  }
+
+  #showAndEnableValueSelect() {
+    this.actionValueTarget.classList.remove("hidden");
+    this.valueSelectEl.disabled = false;
+  }
+
+  #hideAndDisableValueSelect() {
+    this.actionValueTarget.classList.add("hidden");
+    this.valueSelectEl.disabled = true;
+  }
+
+  #updateValueSelectFor(actionExecutor) {
+    // Clear existing options
+    this.valueSelectEl.innerHTML = "";
+
+    // Add new options
+    for (const option of actionExecutor.options) {
+      const optionEl = document.createElement("option");
+      optionEl.value = option[1];
+      optionEl.textContent = option[0];
+      this.valueSelectEl.appendChild(optionEl);
+    }
+  }
+}

app/javascript/controllers/rule/conditions_controller.js

@@ -0,0 +1,104 @@
+import { Controller } from "@hotwired/stimulus";
+
+// Connects to data-controller="rule--conditions"
+export default class extends Controller {
+  static values = { conditionFilters: Array };
+  static targets = [
+    "destroyField",
+    "filterValue",
+    "operatorSelect",
+    "subConditionTemplate",
+    "subConditionsList",
+  ];
+
+  addSubCondition() {
+    const html = this.subConditionTemplateTarget.innerHTML.replaceAll(
+      "IDX_PLACEHOLDER",
+      this.#uniqueKey(),
+    );
+
+    this.subConditionsListTarget.insertAdjacentHTML("beforeend", html);
+  }
+
+  remove(e) {
+    if (e.params.destroy) {
+      this.destroyFieldTarget.value = true;
+      this.element.classList.add("hidden");
+    } else {
+      this.element.remove();
+    }
+  }
+
+  handleConditionTypeChange(e) {
+    const conditionFilter = this.conditionFiltersValue.find(
+      (filter) => filter.key === e.target.value,
+    );
+
+    if (conditionFilter.type === "select") {
+      this.#buildSelectFor(conditionFilter);
+    } else {
+      this.#buildTextInputFor(conditionFilter);
+    }
+
+    this.#updateOperatorsField(conditionFilter);
+  }
+
+  get valueInputEl() {
+    const textInput = this.filterValueTarget.querySelector("input");
+    const selectInput = this.filterValueTarget.querySelector("select");
+
+    return textInput || selectInput;
+  }
+
+  #updateOperatorsField(conditionFilter) {
+    this.operatorSelectTarget.innerHTML = "";
+
+    for (const operator of conditionFilter.operators) {
+      const optionEl = document.createElement("option");
+      optionEl.value = operator[1];
+      optionEl.textContent = operator[0];
+      this.operatorSelectTarget.appendChild(optionEl);
+    }
+  }
+
+  #buildSelectFor(conditionFilter) {
+    const selectEl = this.#convertFormFieldTo("select", this.valueInputEl);
+
+    for (const option of conditionFilter.options) {
+      const optionEl = document.createElement("option");
+      optionEl.value = option[1];
+      optionEl.textContent = option[0];
+      selectEl.appendChild(optionEl);
+    }
+
+    this.valueInputEl.replaceWith(selectEl);
+  }
+
+  #buildTextInputFor(conditionFilter) {
+    const textInput = this.#convertFormFieldTo("input", this.valueInputEl);
+    textInput.placeholder = "Enter a value";
+    textInput.type = conditionFilter.type; // "text" || "number"
+    if (conditionFilter.type === "number") {
+      textInput.step = conditionFilter.number_step;
+    }
+
+    this.valueInputEl.replaceWith(textInput);
+  }
+
+  #convertFormFieldTo(type, el) {
+    const priorClasses = el.classList;
+    const priorId = el.id;
+    const priorName = el.name;
+
+    const newFormField = document.createElement(type);
+    newFormField.classList.add(...priorClasses);
+    newFormField.id = priorId;
+    newFormField.name = priorName;
+
+    return newFormField;
+  }
+
+  #uniqueKey() {
+    return Math.random().toString(36).substring(2, 15);
+  }
+}

app/javascript/controllers/rules_controller.js

@@ -0,0 +1,48 @@
+import { Controller } from "@hotwired/stimulus";
+
+// Connects to data-controller="rules"
+export default class extends Controller {
+  static targets = [
+    "conditionTemplate",
+    "conditionGroupTemplate",
+    "actionTemplate",
+    "conditionsList",
+    "actionsList",
+    "effectiveDateInput",
+  ];
+
+  addConditionGroup() {
+    this.#appendTemplate(
+      this.conditionGroupTemplateTarget,
+      this.conditionsListTarget,
+    );
+  }
+
+  addCondition() {
+    this.#appendTemplate(
+      this.conditionTemplateTarget,
+      this.conditionsListTarget,
+    );
+  }
+
+  addAction() {
+    this.#appendTemplate(this.actionTemplateTarget, this.actionsListTarget);
+  }
+
+  clearEffectiveDate() {
+    this.effectiveDateInputTarget.value = "";
+  }
+
+  #appendTemplate(templateEl, listEl) {
+    const html = templateEl.innerHTML.replaceAll(
+      "IDX_PLACEHOLDER",
+      this.#uniqueKey(),
+    );
+
+    listEl.insertAdjacentHTML("beforeend", html);
+  }
+
+  #uniqueKey() {
+    return Date.now();
+  }
+}