mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-08-02 20:15:22 +02:00
Transaction rules engine V1 (#1900)
* Domain model sketch
* Scaffold out rules domain
* Migrations
* Remove existing data enrichment for clean slate
* Sketch out business logic and basic tests
* Simplify rule scope building and action executions
* Get generator working again
* Basic implementation + tests
* Remove manual merchant management (rules will replace)
* Revert "Remove manual merchant management (rules will replace)"
This reverts commit 83dcbd9ff0
.
* Family and Provider merchants model
* Fix brakeman warnings
* Fix notification loader
* Update notification position
* Add Rule action and condition registries
* Rule form with compound conditions and tests
* Split out notification types, add CTA type
* Rules form builder and Stimulus controller
* Clean up rule registry domain
* Clean up rules stimulus controller
* CTA message for rule when user changes transaction category
* Fix tests
* Lint updates
* Centralize notifications in Notifiable concern
* Implement category rule prompts with auto backoff and option to disable
* Fix layout bug caused by merge conflict
* Initialize rule with correct action for category CTA
* Add rule deletions, get rules working
* Complete dynamic rule form, split Stimulus controllers by resource
* Fix failing tests
* Change test password to avoid chromium conflicts
* Update integration tests
* Centralize all test password references
* Add re-apply rule action
* Rule confirm modal
* Run migrations
* Trigger rule notification after inline category updates
* Clean up rule styles
* Basic attribute locking for rules
* Apply attribute locks on user edits
* Log data enrichments, only apply rules to unlocked attributes
* Fix merge errors
* Additional merge conflict fixes
* Form UI improvements, ignore attribute locks on manual rule application
* Batch AI auto-categorization of transactions
* Auto merchant detection, ai enrichment in batches
* Fix Plaid merchant assignments
* Plaid category matching
* Cleanup 1
* Test cleanup
* Remove stale route
* Fix desktop chat UI issues
* Fix mobile nav styling issues
This commit is contained in:
parent
8edd7ecef0
commit
297a695d0f
152 changed files with 4502 additions and 612 deletions
88
app/models/family/auto_categorizer.rb
Normal file
88
app/models/family/auto_categorizer.rb
Normal file
|
@ -0,0 +1,88 @@
|
|||
class Family::AutoCategorizer
|
||||
Error = Class.new(StandardError)
|
||||
|
||||
def initialize(family, transaction_ids: [])
|
||||
@family = family
|
||||
@transaction_ids = transaction_ids
|
||||
end
|
||||
|
||||
def auto_categorize
|
||||
raise Error, "No LLM provider for auto-categorization" unless llm_provider
|
||||
|
||||
if scope.none?
|
||||
Rails.logger.info("No transactions to auto-categorize for family #{family.id}")
|
||||
return
|
||||
else
|
||||
Rails.logger.info("Auto-categorizing #{scope.count} transactions for family #{family.id}")
|
||||
end
|
||||
|
||||
result = llm_provider.auto_categorize(
|
||||
transactions: transactions_input,
|
||||
user_categories: user_categories_input
|
||||
)
|
||||
|
||||
unless result.success?
|
||||
Rails.logger.error("Failed to auto-categorize transactions for family #{family.id}: #{result.error.message}")
|
||||
return
|
||||
end
|
||||
|
||||
scope.each do |transaction|
|
||||
transaction.lock!(:category_id)
|
||||
|
||||
auto_categorization = result.data.find { |c| c.transaction_id == transaction.id }
|
||||
|
||||
category_id = user_categories_input.find { |c| c[:name] == auto_categorization&.category_name }&.dig(:id)
|
||||
|
||||
if category_id.present?
|
||||
Family.transaction do
|
||||
transaction.log_enrichment!(
|
||||
attribute_name: "category_id",
|
||||
attribute_value: category_id,
|
||||
source: "ai",
|
||||
)
|
||||
|
||||
transaction.update!(category_id: category_id)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
private
|
||||
attr_reader :family, :transaction_ids
|
||||
|
||||
# For now, OpenAI only, but this should work with any LLM concept provider
|
||||
def llm_provider
|
||||
Provider::Registry.get_provider(:openai)
|
||||
end
|
||||
|
||||
def user_categories_input
|
||||
family.categories.map do |category|
|
||||
{
|
||||
id: category.id,
|
||||
name: category.name,
|
||||
is_subcategory: category.subcategory?,
|
||||
parent_id: category.parent_id,
|
||||
classification: category.classification
|
||||
}
|
||||
end
|
||||
end
|
||||
|
||||
def transactions_input
|
||||
scope.map do |transaction|
|
||||
{
|
||||
id: transaction.id,
|
||||
amount: transaction.entry.amount.abs,
|
||||
classification: transaction.entry.classification,
|
||||
description: transaction.entry.name,
|
||||
merchant: transaction.merchant&.name,
|
||||
hint: transaction.plaid_category_detailed
|
||||
}
|
||||
end
|
||||
end
|
||||
|
||||
def scope
|
||||
family.transactions.where(id: transaction_ids, category_id: nil)
|
||||
.enrichable(:category_id)
|
||||
.includes(:category, :merchant, :entry)
|
||||
end
|
||||
end
|
Loading…
Add table
Add a link
Reference in a new issue