mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-08-02 20:15:22 +02:00
Transaction rules engine V1 (#1900)
* Domain model sketch
* Scaffold out rules domain
* Migrations
* Remove existing data enrichment for clean slate
* Sketch out business logic and basic tests
* Simplify rule scope building and action executions
* Get generator working again
* Basic implementation + tests
* Remove manual merchant management (rules will replace)
* Revert "Remove manual merchant management (rules will replace)"
This reverts commit 83dcbd9ff0
.
* Family and Provider merchants model
* Fix brakeman warnings
* Fix notification loader
* Update notification position
* Add Rule action and condition registries
* Rule form with compound conditions and tests
* Split out notification types, add CTA type
* Rules form builder and Stimulus controller
* Clean up rule registry domain
* Clean up rules stimulus controller
* CTA message for rule when user changes transaction category
* Fix tests
* Lint updates
* Centralize notifications in Notifiable concern
* Implement category rule prompts with auto backoff and option to disable
* Fix layout bug caused by merge conflict
* Initialize rule with correct action for category CTA
* Add rule deletions, get rules working
* Complete dynamic rule form, split Stimulus controllers by resource
* Fix failing tests
* Change test password to avoid chromium conflicts
* Update integration tests
* Centralize all test password references
* Add re-apply rule action
* Rule confirm modal
* Run migrations
* Trigger rule notification after inline category updates
* Clean up rule styles
* Basic attribute locking for rules
* Apply attribute locks on user edits
* Log data enrichments, only apply rules to unlocked attributes
* Fix merge errors
* Additional merge conflict fixes
* Form UI improvements, ignore attribute locks on manual rule application
* Batch AI auto-categorization of transactions
* Auto merchant detection, ai enrichment in batches
* Fix Plaid merchant assignments
* Plaid category matching
* Cleanup 1
* Test cleanup
* Remove stale route
* Fix desktop chat UI issues
* Fix mobile nav styling issues
This commit is contained in:
parent
8edd7ecef0
commit
297a695d0f
152 changed files with 4502 additions and 612 deletions
62
app/models/rule/condition.rb
Normal file
62
app/models/rule/condition.rb
Normal file
|
@ -0,0 +1,62 @@
|
|||
class Rule::Condition < ApplicationRecord
|
||||
belongs_to :rule, optional: -> { where.not(parent_id: nil) }
|
||||
belongs_to :parent, class_name: "Rule::Condition", optional: true, inverse_of: :sub_conditions
|
||||
|
||||
has_many :sub_conditions, class_name: "Rule::Condition", foreign_key: :parent_id, dependent: :destroy, inverse_of: :parent
|
||||
|
||||
validates :condition_type, presence: true
|
||||
validates :operator, presence: true
|
||||
validates :value, presence: true, unless: -> { compound? }
|
||||
|
||||
accepts_nested_attributes_for :sub_conditions, allow_destroy: true
|
||||
|
||||
# We don't store rule_id on sub_conditions, so "walk up" to the parent rule
|
||||
def rule
|
||||
parent&.rule || super
|
||||
end
|
||||
|
||||
def compound?
|
||||
condition_type == "compound"
|
||||
end
|
||||
|
||||
def apply(scope)
|
||||
if compound?
|
||||
build_compound_scope(scope)
|
||||
else
|
||||
filter.apply(scope, operator, value)
|
||||
end
|
||||
end
|
||||
|
||||
def prepare(scope)
|
||||
if compound?
|
||||
sub_conditions.reduce(scope) { |s, sub| sub.prepare(s) }
|
||||
else
|
||||
filter.prepare(scope)
|
||||
end
|
||||
end
|
||||
|
||||
def options
|
||||
filter.options
|
||||
end
|
||||
|
||||
def operators
|
||||
filter.operators
|
||||
end
|
||||
|
||||
def filter
|
||||
rule.registry.get_filter!(condition_type)
|
||||
end
|
||||
|
||||
private
|
||||
def build_compound_scope(scope)
|
||||
if operator == "or"
|
||||
combined_scope = sub_conditions
|
||||
.map { |sub| sub.apply(scope) }
|
||||
.reduce { |acc, s| acc.or(s) }
|
||||
|
||||
combined_scope || scope
|
||||
else
|
||||
sub_conditions.reduce(scope) { |s, sub| sub.apply(s) }
|
||||
end
|
||||
end
|
||||
end
|
Loading…
Add table
Add a link
Reference in a new issue