mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-08-07 22:45:20 +02:00
Transaction rules engine V1 (#1900)
* Domain model sketch
* Scaffold out rules domain
* Migrations
* Remove existing data enrichment for clean slate
* Sketch out business logic and basic tests
* Simplify rule scope building and action executions
* Get generator working again
* Basic implementation + tests
* Remove manual merchant management (rules will replace)
* Revert "Remove manual merchant management (rules will replace)"
This reverts commit 83dcbd9ff0
.
* Family and Provider merchants model
* Fix brakeman warnings
* Fix notification loader
* Update notification position
* Add Rule action and condition registries
* Rule form with compound conditions and tests
* Split out notification types, add CTA type
* Rules form builder and Stimulus controller
* Clean up rule registry domain
* Clean up rules stimulus controller
* CTA message for rule when user changes transaction category
* Fix tests
* Lint updates
* Centralize notifications in Notifiable concern
* Implement category rule prompts with auto backoff and option to disable
* Fix layout bug caused by merge conflict
* Initialize rule with correct action for category CTA
* Add rule deletions, get rules working
* Complete dynamic rule form, split Stimulus controllers by resource
* Fix failing tests
* Change test password to avoid chromium conflicts
* Update integration tests
* Centralize all test password references
* Add re-apply rule action
* Rule confirm modal
* Run migrations
* Trigger rule notification after inline category updates
* Clean up rule styles
* Basic attribute locking for rules
* Apply attribute locks on user edits
* Log data enrichments, only apply rules to unlocked attributes
* Fix merge errors
* Additional merge conflict fixes
* Form UI improvements, ignore attribute locks on manual rule application
* Batch AI auto-categorization of transactions
* Auto merchant detection, ai enrichment in batches
* Fix Plaid merchant assignments
* Plaid category matching
* Cleanup 1
* Test cleanup
* Remove stale route
* Fix desktop chat UI issues
* Fix mobile nav styling issues
This commit is contained in:
parent
8edd7ecef0
commit
297a695d0f
152 changed files with 4502 additions and 612 deletions
27
app/views/rule/actions/_action.html.erb
Normal file
27
app/views/rule/actions/_action.html.erb
Normal file
|
@ -0,0 +1,27 @@
|
|||
<%# locals: (form:) %>
|
||||
|
||||
<% action = form.object %>
|
||||
<% rule = action.rule %>
|
||||
<% needs_value = action.executor.type == "select" %>
|
||||
|
||||
<li data-controller="rule--actions" data-rule--actions-action-executors-value="<%= rule.action_executors.to_json %>" class="flex items-center gap-3">
|
||||
<%= form.hidden_field :_destroy, value: false, data: { rule__actions_target: "destroyField" } %>
|
||||
|
||||
<div class="grow flex gap-2 items-center h-full">
|
||||
<div class="grow">
|
||||
<%= form.select :action_type, rule.action_executors.map { |executor| [ executor.label, executor.key ] }, {}, data: { action: "rule--actions#handleActionTypeChange" } %>
|
||||
</div>
|
||||
|
||||
<%= tag.div class: class_names("min-w-1/2 flex items-center gap-2", "hidden" => !needs_value),
|
||||
data: { rule__actions_target: "actionValue" } do %>
|
||||
<span class="font-medium uppercase text-xs">to</span>
|
||||
<%= form.select :value, action.options || [], {}, disabled: !needs_value %>
|
||||
<% end %>
|
||||
</div>
|
||||
|
||||
<button type="button"
|
||||
data-action="rule--actions#remove"
|
||||
data-rule--actions-destroy-param="<%= action.persisted? %>">
|
||||
<%= icon("trash-2", color: "gray", size: "sm") %>
|
||||
</button>
|
||||
</li>
|
40
app/views/rule/conditions/_condition.html.erb
Normal file
40
app/views/rule/conditions/_condition.html.erb
Normal file
|
@ -0,0 +1,40 @@
|
|||
<%# locals: (form:, show_prefix: true) %>
|
||||
|
||||
<% condition = form.object %>
|
||||
<% rule = condition.rule %>
|
||||
|
||||
<li data-controller="rule--conditions" data-rule--conditions-condition-filters-value="<%= rule.condition_filters.to_json %>" class="flex items-center gap-3">
|
||||
<% if form.index.to_i > 0 && show_prefix %>
|
||||
<div class="pl-4">
|
||||
<span class="font-medium uppercase text-xs">and</span>
|
||||
</div>
|
||||
<% end %>
|
||||
|
||||
<div class="grow flex gap-2 items-center h-full">
|
||||
<%= form.hidden_field :_destroy, value: false, data: { rule__conditions_target: "destroyField" } %>
|
||||
|
||||
<div class="w-2/5 shrink-0">
|
||||
<%= form.select :condition_type, rule.condition_filters.map { |filter| [ filter.label, filter.key ] }, {}, data: { action: "rule--conditions#handleConditionTypeChange" } %>
|
||||
</div>
|
||||
|
||||
<%= form.select :operator, condition.operators, { container_class: "w-fit min-w-36" }, data: { rule__conditions_target: "operatorSelect" } %>
|
||||
|
||||
<div data-rule--conditions-target="filterValue" class="grow">
|
||||
<% if condition.filter.type == "select" %>
|
||||
<%= form.select :value, condition.options, {} %>
|
||||
<% else %>
|
||||
<% if condition.filter.type == "number" %>
|
||||
<%= form.number_field :value, placeholder: "10", step: 0.01 %>
|
||||
<% else %>
|
||||
<%= form.text_field :value, placeholder: "Enter a value" %>
|
||||
<% end %>
|
||||
<% end %>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<button type="button"
|
||||
data-action="rule--conditions#remove"
|
||||
data-rule--conditions-destroy-param="<%= condition.persisted? %>">
|
||||
<%= icon("trash-2", color: "gray", size: "sm") %>
|
||||
</button>
|
||||
</li>
|
44
app/views/rule/conditions/_condition_group.html.erb
Normal file
44
app/views/rule/conditions/_condition_group.html.erb
Normal file
|
@ -0,0 +1,44 @@
|
|||
<%# locals: (form:) %>
|
||||
|
||||
<% condition = form.object %>
|
||||
<% rule = condition.rule %>
|
||||
|
||||
<li data-controller="rule--conditions element-removal" class="border border-alpha-black-100 rounded-md p-4 space-y-3">
|
||||
|
||||
<%= form.hidden_field :condition_type, value: "compound" %>
|
||||
|
||||
<div class="flex items-center justify-between gap-2">
|
||||
<div class="flex items-center gap-2">
|
||||
<% unless form.index == 0 %>
|
||||
<div class="pl-2">
|
||||
<span class="font-medium uppercase text-xs">and</span>
|
||||
</div>
|
||||
<% end %>
|
||||
<p class="text-sm text-secondary">match</p>
|
||||
<%= form.select :operator, [["all", "and"], ["any", "or"]], { container_class: "w-fit" }, data: { rules_target: "operatorField" } %>
|
||||
<p class="text-sm text-secondary">of the following conditions</p>
|
||||
</div>
|
||||
|
||||
<button type="button" data-action="element-removal#remove">
|
||||
<%= icon("trash-2", color: "gray", size: "sm") %>
|
||||
</button>
|
||||
</div>
|
||||
|
||||
<%# Sub-condition template, used by Stimulus controller to add new sub-conditions dynamically %>
|
||||
<template data-rule--conditions-target="subConditionTemplate">
|
||||
<%= form.fields_for :sub_conditions, Rule::Condition.new(parent: condition, condition_type: rule.condition_filters.first.key), child_index: "IDX_PLACEHOLDER" do |scf| %>
|
||||
<%= render "rule/conditions/condition", form: scf %>
|
||||
<% end %>
|
||||
</template>
|
||||
|
||||
<ul data-rule--conditions-target="subConditionsList" class="space-y-3">
|
||||
<%= form.fields_for :sub_conditions do |scf| %>
|
||||
<%= render "rule/conditions/condition", form: scf, show_prefix: false %>
|
||||
<% end %>
|
||||
</ul>
|
||||
|
||||
<button type="button" class="btn btn--ghost" data-action="rule--conditions#addSubCondition">
|
||||
<%= icon("plus", color: "gray", size: "sm") %>
|
||||
<span>Add condition</span>
|
||||
</button>
|
||||
</li>
|
Loading…
Add table
Add a link
Reference in a new issue