1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00

Transaction rules engine V1 (#1900)

* Domain model sketch

* Scaffold out rules domain

* Migrations

* Remove existing data enrichment for clean slate

* Sketch out business logic and basic tests

* Simplify rule scope building and action executions

* Get generator working again

* Basic implementation + tests

* Remove manual merchant management (rules will replace)

* Revert "Remove manual merchant management (rules will replace)"

This reverts commit 83dcbd9ff0.

* Family and Provider merchants model

* Fix brakeman warnings

* Fix notification loader

* Update notification position

* Add Rule action and condition registries

* Rule form with compound conditions and tests

* Split out notification types, add CTA type

* Rules form builder and Stimulus controller

* Clean up rule registry domain

* Clean up rules stimulus controller

* CTA message for rule when user changes transaction category

* Fix tests

* Lint updates

* Centralize notifications in Notifiable concern

* Implement category rule prompts with auto backoff and option to disable

* Fix layout bug caused by merge conflict

* Initialize rule with correct action for category CTA

* Add rule deletions, get rules working

* Complete dynamic rule form, split Stimulus controllers by resource

* Fix failing tests

* Change test password to avoid chromium conflicts

* Update integration tests

* Centralize all test password references

* Add re-apply rule action

* Rule confirm modal

* Run migrations

* Trigger rule notification after inline category updates

* Clean up rule styles

* Basic attribute locking for rules

* Apply attribute locks on user edits

* Log data enrichments, only apply rules to unlocked attributes

* Fix merge errors

* Additional merge conflict fixes

* Form UI improvements, ignore attribute locks on manual rule application

* Batch AI auto-categorization of transactions

* Auto merchant detection, ai enrichment in batches

* Fix Plaid merchant assignments

* Plaid category matching

* Cleanup 1

* Test cleanup

* Remove stale route

* Fix desktop chat UI issues

* Fix mobile nav styling issues
This commit is contained in:
Zach Gollwitzer 2025-04-18 11:39:58 -04:00 committed by GitHub
parent 8edd7ecef0
commit 297a695d0f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
152 changed files with 4502 additions and 612 deletions

View file

@ -0,0 +1,33 @@
class AddRulesEngine < ActiveRecord::Migration[7.2]
def change
create_table :rules, id: :uuid do |t|
t.references :family, null: false, foreign_key: true, type: :uuid
t.string :resource_type, null: false
t.date :effective_date
t.boolean :active, null: false, default: false
t.timestamps
end
create_table :rule_conditions, id: :uuid do |t|
t.references :rule, foreign_key: true, type: :uuid
t.references :parent, foreign_key: { to_table: :rule_conditions }, type: :uuid
t.string :condition_type, null: false
t.string :operator, null: false
t.string :value
t.timestamps
end
create_table :rule_actions, id: :uuid do |t|
t.references :rule, null: false, foreign_key: true, type: :uuid
t.string :action_type, null: false
t.string :value
t.timestamps
end
add_column :users, :rule_prompts_disabled, :boolean, default: false
add_column :users, :rule_prompt_dismissed_at, :datetime
end
end

View file

@ -0,0 +1,33 @@
class AddDataEnrichments < ActiveRecord::Migration[7.2]
def change
create_table :data_enrichments, id: :uuid do |t|
t.references :enrichable, polymorphic: true, null: false, type: :uuid
t.string :source
t.string :attribute_name
t.jsonb :value
t.jsonb :metadata
t.timestamps
end
add_index :data_enrichments, [ :enrichable_id, :enrichable_type, :source, :attribute_name ], unique: true
# Entries
add_column :entries, :locked_attributes, :jsonb, default: {}
add_column :transactions, :locked_attributes, :jsonb, default: {}
add_column :trades, :locked_attributes, :jsonb, default: {}
add_column :valuations, :locked_attributes, :jsonb, default: {}
# Accounts
add_column :accounts, :locked_attributes, :jsonb, default: {}
add_column :depositories, :locked_attributes, :jsonb, default: {}
add_column :investments, :locked_attributes, :jsonb, default: {}
add_column :cryptos, :locked_attributes, :jsonb, default: {}
add_column :properties, :locked_attributes, :jsonb, default: {}
add_column :vehicles, :locked_attributes, :jsonb, default: {}
add_column :other_assets, :locked_attributes, :jsonb, default: {}
add_column :credit_cards, :locked_attributes, :jsonb, default: {}
add_column :loans, :locked_attributes, :jsonb, default: {}
add_column :other_liabilities, :locked_attributes, :jsonb, default: {}
end
end

View file

@ -0,0 +1,34 @@
class MerchantAndCategoryEnrichment < ActiveRecord::Migration[7.2]
def change
change_column_null :merchants, :family_id, true
change_column_null :merchants, :color, true
change_column_default :merchants, :color, from: "#e99537", to: nil
remove_column :merchants, :enriched_at, :datetime
rename_column :merchants, :icon_url, :logo_url
add_column :merchants, :website_url, :string
add_column :merchants, :type, :string
add_index :merchants, :type
reversible do |dir|
dir.up do
# All of our existing merchants are family-generated right now
Merchant.update_all(type: "FamilyMerchant")
end
end
change_column_null :merchants, :type, false
add_column :merchants, :source, :string
add_column :merchants, :provider_merchant_id, :string
add_index :merchants, [ :family_id, :name ], unique: true, where: "type = 'FamilyMerchant'"
add_index :merchants, [ :source, :name ], unique: true, where: "type = 'ProviderMerchant'"
add_column :transactions, :plaid_category, :string
add_column :transactions, :plaid_category_detailed, :string
remove_column :entries, :enriched_name, :string
remove_column :entries, :enriched_at, :datetime
end
end