1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-05 05:25:24 +02:00

Transaction rules engine V1 (#1900)

* Domain model sketch

* Scaffold out rules domain

* Migrations

* Remove existing data enrichment for clean slate

* Sketch out business logic and basic tests

* Simplify rule scope building and action executions

* Get generator working again

* Basic implementation + tests

* Remove manual merchant management (rules will replace)

* Revert "Remove manual merchant management (rules will replace)"

This reverts commit 83dcbd9ff0.

* Family and Provider merchants model

* Fix brakeman warnings

* Fix notification loader

* Update notification position

* Add Rule action and condition registries

* Rule form with compound conditions and tests

* Split out notification types, add CTA type

* Rules form builder and Stimulus controller

* Clean up rule registry domain

* Clean up rules stimulus controller

* CTA message for rule when user changes transaction category

* Fix tests

* Lint updates

* Centralize notifications in Notifiable concern

* Implement category rule prompts with auto backoff and option to disable

* Fix layout bug caused by merge conflict

* Initialize rule with correct action for category CTA

* Add rule deletions, get rules working

* Complete dynamic rule form, split Stimulus controllers by resource

* Fix failing tests

* Change test password to avoid chromium conflicts

* Update integration tests

* Centralize all test password references

* Add re-apply rule action

* Rule confirm modal

* Run migrations

* Trigger rule notification after inline category updates

* Clean up rule styles

* Basic attribute locking for rules

* Apply attribute locks on user edits

* Log data enrichments, only apply rules to unlocked attributes

* Fix merge errors

* Additional merge conflict fixes

* Form UI improvements, ignore attribute locks on manual rule application

* Batch AI auto-categorization of transactions

* Auto merchant detection, ai enrichment in batches

* Fix Plaid merchant assignments

* Plaid category matching

* Cleanup 1

* Test cleanup

* Remove stale route

* Fix desktop chat UI issues

* Fix mobile nav styling issues
This commit is contained in:
Zach Gollwitzer 2025-04-18 11:39:58 -04:00 committed by GitHub
parent 8edd7ecef0
commit 297a695d0f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
152 changed files with 4502 additions and 612 deletions

View file

@ -0,0 +1,136 @@
require "test_helper"
class Provider::Plaid::CategoryAliasMatcherTest < ActiveSupport::TestCase
setup do
@family = families(:empty)
# User income categories
@income = @family.categories.create!(name: "Income", classification: "income")
@dividend_income = @family.categories.create!(name: "Dividend Income", parent: @income, classification: "income")
@interest_income = @family.categories.create!(name: "Interest Income", parent: @income, classification: "income")
# User expense categories
@loan_payments = @family.categories.create!(name: "Loan Payments")
@fees = @family.categories.create!(name: "Fees")
@entertainment = @family.categories.create!(name: "Entertainment")
@food_and_drink = @family.categories.create!(name: "Food & Drink")
@groceries = @family.categories.create!(name: "Groceries", parent: @food_and_drink)
@restaurant = @family.categories.create!(name: "Restaurant", parent: @food_and_drink)
@shopping = @family.categories.create!(name: "Shopping")
@clothing = @family.categories.create!(name: "Clothing", parent: @shopping)
@home = @family.categories.create!(name: "Home")
@medical = @family.categories.create!(name: "Medical")
@personal_care = @family.categories.create!(name: "Personal Care")
@transportation = @family.categories.create!(name: "Transportation")
@trips = @family.categories.create!(name: "Trips")
@services = @family.categories.create!(name: "Services")
@car = @family.categories.create!(name: "Car", parent: @services)
@giving = @family.categories.create!(name: "Giving")
@matcher = Provider::Plaid::CategoryAliasMatcher.new(@family.categories)
end
test "matches expense categories" do
assert_equal @loan_payments, @matcher.match("loan_payments_car_payment")
assert_equal @loan_payments, @matcher.match("loan_payments_credit_card_payment")
assert_equal @loan_payments, @matcher.match("loan_payments_personal_loan_payment")
assert_equal @loan_payments, @matcher.match("loan_payments_mortgage_payment")
assert_equal @loan_payments, @matcher.match("loan_payments_student_loan_payment")
assert_equal @loan_payments, @matcher.match("loan_payments_other_payment")
assert_equal @fees, @matcher.match("bank_fees_atm_fees")
assert_equal @fees, @matcher.match("bank_fees_foreign_transaction_fees")
assert_equal @fees, @matcher.match("bank_fees_insufficient_funds")
assert_equal @fees, @matcher.match("bank_fees_interest_charge")
assert_equal @fees, @matcher.match("bank_fees_overdraft_fees")
assert_equal @fees, @matcher.match("bank_fees_other_bank_fees")
assert_equal @entertainment, @matcher.match("entertainment_casinos_and_gambling")
assert_equal @entertainment, @matcher.match("entertainment_music_and_audio")
assert_equal @entertainment, @matcher.match("entertainment_sporting_events_amusement_parks_and_museums")
assert_equal @entertainment, @matcher.match("entertainment_tv_and_movies")
assert_equal @entertainment, @matcher.match("entertainment_video_games")
assert_equal @entertainment, @matcher.match("entertainment_other_entertainment")
assert_equal @food_and_drink, @matcher.match("food_and_drink_beer_wine_and_liquor")
assert_equal @food_and_drink, @matcher.match("food_and_drink_coffee")
assert_equal @food_and_drink, @matcher.match("food_and_drink_fast_food")
assert_equal @groceries, @matcher.match("food_and_drink_groceries")
assert_equal @restaurant, @matcher.match("food_and_drink_restaurant")
assert_equal @food_and_drink, @matcher.match("food_and_drink_vending_machines")
assert_equal @food_and_drink, @matcher.match("food_and_drink_other_food_and_drink")
assert_equal @shopping, @matcher.match("general_merchandise_bookstores_and_newsstands")
assert_equal @clothing, @matcher.match("general_merchandise_clothing_and_accessories")
assert_equal @shopping, @matcher.match("general_merchandise_convenience_stores")
assert_equal @shopping, @matcher.match("general_merchandise_department_stores")
assert_equal @shopping, @matcher.match("general_merchandise_discount_stores")
assert_equal @shopping, @matcher.match("general_merchandise_electronics")
assert_equal @shopping, @matcher.match("general_merchandise_gifts_and_novelties")
assert_equal @shopping, @matcher.match("general_merchandise_office_supplies")
assert_equal @shopping, @matcher.match("general_merchandise_online_marketplaces")
assert_equal @shopping, @matcher.match("general_merchandise_pet_supplies")
assert_equal @shopping, @matcher.match("general_merchandise_sporting_goods")
assert_equal @shopping, @matcher.match("general_merchandise_superstores")
assert_equal @shopping, @matcher.match("general_merchandise_tobacco_and_vape")
assert_equal @shopping, @matcher.match("general_merchandise_other_general_merchandise")
assert_equal @home, @matcher.match("home_improvement_furniture")
assert_equal @home, @matcher.match("home_improvement_hardware")
assert_equal @home, @matcher.match("home_improvement_repair_and_maintenance")
assert_equal @home, @matcher.match("home_improvement_security")
assert_equal @home, @matcher.match("home_improvement_other_home_improvement")
assert_equal @medical, @matcher.match("medical_dental_care")
assert_equal @medical, @matcher.match("medical_eye_care")
assert_equal @medical, @matcher.match("medical_nursing_care")
assert_equal @medical, @matcher.match("medical_pharmacies_and_supplements")
assert_equal @medical, @matcher.match("medical_primary_care")
assert_equal @medical, @matcher.match("medical_veterinary_services")
assert_equal @medical, @matcher.match("medical_other_medical")
assert_equal @personal_care, @matcher.match("personal_care_gyms_and_fitness_centers")
assert_equal @personal_care, @matcher.match("personal_care_hair_and_beauty")
assert_equal @personal_care, @matcher.match("personal_care_laundry_and_dry_cleaning")
assert_equal @personal_care, @matcher.match("personal_care_other_personal_care")
assert_equal @services, @matcher.match("general_services_accounting_and_financial_planning")
assert_equal @car, @matcher.match("general_services_automotive")
assert_equal @services, @matcher.match("general_services_childcare")
assert_equal @services, @matcher.match("general_services_consulting_and_legal")
assert_equal @services, @matcher.match("general_services_education")
assert_equal @services, @matcher.match("general_services_insurance")
assert_equal @services, @matcher.match("general_services_postage_and_shipping")
assert_equal @services, @matcher.match("general_services_storage")
assert_equal @services, @matcher.match("general_services_other_general_services")
assert_equal @giving, @matcher.match("government_and_non_profit_donations")
assert_nil @matcher.match("government_and_non_profit_government_departments_and_agencies")
assert_nil @matcher.match("government_and_non_profit_tax_payment")
assert_nil @matcher.match("government_and_non_profit_other_government_and_non_profit")
assert_equal @transportation, @matcher.match("transportation_bikes_and_scooters")
assert_equal @transportation, @matcher.match("transportation_gas")
assert_equal @transportation, @matcher.match("transportation_parking")
assert_equal @transportation, @matcher.match("transportation_public_transit")
assert_equal @transportation, @matcher.match("transportation_taxis_and_ride_shares")
assert_equal @transportation, @matcher.match("transportation_tolls")
assert_equal @transportation, @matcher.match("transportation_other_transportation")
assert_equal @trips, @matcher.match("travel_flights")
assert_equal @trips, @matcher.match("travel_lodging")
assert_equal @trips, @matcher.match("travel_rental_cars")
assert_equal @trips, @matcher.match("travel_other_travel")
assert_equal @home, @matcher.match("rent_and_utilities_gas_and_electricity")
assert_equal @home, @matcher.match("rent_and_utilities_internet_and_cable")
assert_equal @home, @matcher.match("rent_and_utilities_rent")
assert_equal @home, @matcher.match("rent_and_utilities_sewage_and_waste_management")
assert_equal @home, @matcher.match("rent_and_utilities_telephone")
assert_equal @home, @matcher.match("rent_and_utilities_water")
assert_equal @home, @matcher.match("rent_and_utilities_other_utilities")
end
test "matches income categories" do
assert_equal @dividend_income, @matcher.match("income_dividends")
assert_equal @interest_income, @matcher.match("income_interest_earned")
assert_equal @income, @matcher.match("income_tax_refund")
assert_equal @income, @matcher.match("income_retirement_pension")
assert_equal @income, @matcher.match("income_unemployment")
assert_equal @income, @matcher.match("income_wages")
assert_equal @income, @matcher.match("income_other_income")
end
end