Transfer and Payment auto-matching, model and UI improvements (#1585)

* Transfer data model migration

* Transfers and payment modeling and UI improvements

* Fix CI

* Transfer matching flow

* Better UI for transfers

* Auto transfer matching, approve, reject flow

* Mark transfers created from form as confirmed

* Account filtering

* Excluded rejected transfers from calculations

* Calculation tweaks with transfer exclusions

* Clean up migration

app/helpers/account/entries_helper.rb

@@ -3,10 +3,6 @@ module Account::EntriesHelper
     "account/entries/entryables/#{permitted_entryable_key(entry)}/#{relative_partial_path}"
   end
 
-  def unconfirmed_transfer?(entry)
-    entry.marked_as_transfer? && entry.transfer.nil?
-  end
-
   def transfer_entries(entries)
     transfers = entries.select { |e| e.transfer_id.present? }
     transfers.map(&:transfer).uniq
@@ -18,8 +14,19 @@ module Account::EntriesHelper
         yield grouped_entries
       end
 
+      next if content.blank?
+
       render partial: "account/entries/entry_group", locals: { date:, entries: grouped_entries, content:, selectable:, totals: }
-    end.join.html_safe
+    end.compact.join.html_safe
+  end
+
+  def entry_name_detailed(entry)
+    [
+      entry.date,
+      format_money(entry.amount_money),
+      entry.account.name,
+      entry.display_name
+    ].join(" • ")
   end
 
   private

app/helpers/account/transfers_helper.rb

@@ -1,2 +0,0 @@
-module Account::TransfersHelper
-end

app/helpers/application_helper.rb

@@ -67,9 +67,9 @@ module ApplicationHelper
     render partial: "shared/drawer", locals: { content:, reload_on_close: }
   end
 
-  def disclosure(title, &block)
+  def disclosure(title, default_open: true, &block)
     content = capture &block
-    render partial: "shared/disclosure", locals: { title: title, content: content }
+    render partial: "shared/disclosure", locals: { title: title, content: content, open: default_open }
   end
 
   def sidebar_link_to(name, path, options = {})

app/helpers/categories_helper.rb

@@ -5,6 +5,24 @@ module CategoriesHelper
       color: Category::UNCATEGORIZED_COLOR
   end
 
+  def transfer_category
+    Category.new \
+      name: "⇄ Transfer",
+      color: Category::TRANSFER_COLOR
+  end
+
+  def payment_category
+    Category.new \
+      name: "→ Payment",
+      color: Category::PAYMENT_COLOR
+  end
+
+  def trade_category
+    Category.new \
+      name: "Trade",
+      color: Category::TRADE_COLOR
+  end
+
   def family_categories
     [ null_category ].concat(Current.family.categories.alphabetically)
   end