Account Sync should happen at login, 1x per day, OR on-demand (#594)

* Add last_sync_date to accounts table

* Always sync Account after Valuation or Transaction creation, update, or deletion.

Skip sync if user clicks "sync" button without changing anything

* Sync user accounts daily based on last_login_at

app/controllers/accounts_controller.rb

@@ -20,7 +20,7 @@ class AccountsController < ApplicationController
   def update
     if @account.update(account_params.except(:accountable_type))
 
-      @account.sync_later if account_params[:is_active] == "1"
+      @account.sync_later if account_params[:is_active] == "1" && @account.can_sync?
 
       respond_to do |format|
         format.html { redirect_to accounts_path, notice: t(".success") }
@@ -53,15 +53,12 @@ class AccountsController < ApplicationController
   end
 
   def sync
-    @account.sync_later
+    @account.sync_later if @account.can_sync?
 
     respond_to do |format|
       format.html { redirect_to account_path(@account), notice: t(".success") }
       format.turbo_stream do
-        render turbo_stream: [
-          turbo_stream.append("notification-tray", partial: "shared/notification", locals: { type: "success", content: t(".success") }),
-          turbo_stream.replace("sync_message", partial: "accounts/sync_message", locals: { is_syncing: true })
-        ]
+        render turbo_stream: turbo_stream.append("notification-tray", partial: "shared/notification", locals: { type: "success", content: t(".success") })
       end
     end
   end

app/controllers/application_controller.rb

@@ -2,6 +2,8 @@ class ApplicationController < ActionController::Base
   include Authentication
   include Pagy::Backend
 
+  before_action :sync_accounts
+
   default_form_builder ApplicationFormBuilder
 
   # Only allow modern browsers supporting webp images, web push, badges, import maps, CSS nesting, and CSS :has.
@@ -13,4 +15,12 @@ class ApplicationController < ActionController::Base
     ENV["HOSTED"] == "true"
   end
   helper_method :hosted_app?
+
+  def sync_accounts
+    return if Current.user.blank?
+
+    if Current.user.last_login_at.nil? || Current.user.last_login_at.before?(Date.current.beginning_of_day)
+      Current.family.sync_accounts
+    end
+  end
 end

app/controllers/concerns/authentication.rb

@@ -3,11 +3,13 @@ module Authentication
 
   included do
     before_action :authenticate_user!
+    after_action :set_last_login_at
   end
 
   class_methods do
     def skip_authentication(**options)
       skip_before_action :authenticate_user!, **options
+      skip_after_action :set_last_login_at, **options
     end
   end
 
@@ -31,4 +33,8 @@ module Authentication
     Current.user = nil
     reset_session
   end
+
+  def set_last_login_at
+    Current.user.update(last_login_at: DateTime.now)
+  end
 end