From 34ebd96c4c5608f4a37363fe263c2492ba27996b Mon Sep 17 00:00:00 2001
From: Aaron Meese <ajmeese7@gmail.com>
Date: Thu, 10 Oct 2024 15:03:47 -0700
Subject: [PATCH] fix: default value if user's name isn't set (#1262)

* fix: default value if user's name isn't set

* chore: matched code style

* fix: i18n key for fallback greeting

---------

Co-authored-by: Zach Gollwitzer <zach@maybe.co>
---
 app/views/pages/dashboard.html.erb | 4 +++-
 config/locales/views/pages/en.yml  | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/app/views/pages/dashboard.html.erb b/app/views/pages/dashboard.html.erb
index 68023607..64fecd9f 100644
--- a/app/views/pages/dashboard.html.erb
+++ b/app/views/pages/dashboard.html.erb
@@ -2,7 +2,9 @@
   <header class="flex items-center justify-between">
     <div>
       <h1 class="sr-only"><%= t(".title") %></h1>
-      <p class="text-xl font-medium text-gray-900 mb-1"><%= t(".greeting", name: Current.user.first_name ) %></p>
+      <p class="text-xl font-medium text-gray-900 mb-1">
+        <%= Current.user.first_name.present? ? t(".greeting", name: Current.user.first_name ) : t(".fallback_greeting") %>
+      </p>
       <% unless @accounts.blank? %>
         <p class="text-gray-500 text-sm"><%= t(".subtitle") %></p>
       <% end %>
diff --git a/config/locales/views/pages/en.yml b/config/locales/views/pages/en.yml
index 493632ff..31152abb 100644
--- a/config/locales/views/pages/en.yml
+++ b/config/locales/views/pages/en.yml
@@ -8,6 +8,7 @@ en:
         assets: Assets
         debts: Debts
       greeting: Welcome back, %{name}
+      fallback_greeting: Welcome back, friend
       import: Import
       income: Income
       investing: Investing (coming soon...)