Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-19 05:09:38 +02:00
Code Issues Releases Activity Actions 1

Fix: i18n symbol typo (#1085)

Browse source
This commit is contained in:
Pedro Carmona 2024-08-13 17:31:51 +01:00 • committed by GitHub
parent 82d3b8bcaf
commit 3c64f3ff3b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/time_series/value.rb
View file

@ -41,7 +41,7 @@ class TimeSeries::Value
def value_must_be_of_known_type
unless value.is_a?(Money) || value.is_a?(Numeric)
# i18n-tasks-use t('activemodel.errors.models.time_series/value.attributes.value.must_be_a_money_or_numeric')
errors.add :value, must_be_a_money_or_numeric
errors.add :value, :must_be_a_money_or_numeric
end
end
end

30
test/models/time_series_test.rb
View file

@ -69,4 +69,34 @@ class TimeSeriesTest < ActiveSupport::TestCase
assert_equal expected_values, series.to_json
end
test "it does not accept invalid values in Time Series Trend" do
error = assert_raises(ActiveModel::ValidationError) do
TimeSeries.new(
[
{ date: 1.day.ago.to_date, value: 100 },
{ date: Date.current, value: "two hundred" }
]
)
end
assert_match(/Current must be of the same type as previous/, error.message)
assert_match(/Previous must be of the same type as current/, error.message)
assert_match(/Current must be of type Money, Numeric, or nil/, error.message)
end
test "it does not accept invalid values in Time Series Value" do
# We need to stub trend otherwise an error is raised before TimeSeries::Value validation
TimeSeries::Trend.stub(:new, nil) do
error = assert_raises(ActiveModel::ValidationError) do
TimeSeries.new(
[
{ date: 1.day.ago.to_date, value: 100 },
{ date: Date.current, value: "two hundred" }
]
)
end
assert_equal "Validation failed: Value must be a Money or Numeric", error.message
end
end
end