Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-24 15:49:39 +02:00
Code Issues Releases Activity Actions 1

Allow transfers based on transactions in different currencies (#903)

Browse source 
* Allow transfers between transactions in different currencies

* Review fixes
This commit is contained in:
Jakub Kottnauer 2024-06-21 23:04:15 +02:00 • committed by GitHub
parent 12380dc8ad
commit 3cae528dfd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/models/account/transfer.rb
View file

@ -1,7 +1,8 @@
class Account::Transfer < ApplicationRecord
has_many :transactions, dependent: :nullify
validate :transaction_count, :from_different_accounts, :net_zero_flows, :all_transactions_marked
validate :net_zero_flows, if: :single_currency_transfer?
validate :transaction_count, :from_different_accounts, :all_transactions_marked
def inflow_transaction
transactions.find { |t| t.inflow? }
@ -32,6 +33,10 @@ class Account::Transfer < ApplicationRecord
private
def single_currency_transfer?
transactions.map(&:currency).uniq.size == 1
end
def transaction_count
unless transactions.size == 2
errors.add :transactions, "must have exactly 2 transactions"

9
test/models/account/transfer_test.rb
View file

@ -39,11 +39,18 @@ class Account::TransferTest < ActiveSupport::TestCase
end
end
test "transfer transactions must net to zero" do
test "single-currency transfer transactions must net to zero" do
@outflow.update! amount: 105
assert_raises ActiveRecord::RecordInvalid do
Account::Transfer.create! transactions: [ @inflow, @outflow ]
end
end
test "multi-currency transfer transactions do not have to net to zero" do
@outflow.update! amount: 105, currency: "EUR"
transfer = Account::Transfer.create! transactions: [ @inflow, @outflow ]
assert transfer.valid?
end
end