Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-05 13:35:21 +02:00
Code Issues Releases Activity Actions

Add auto-update strategies for current balance on manual accounts (#2460)
Some checks are pending
Publish Docker image / ci (push) Waiting to run
Details
Publish Docker image / Build docker image (push) Blocked by required conditions
Details

Browse source 
* Add auto-update strategies for current balance on manual accounts

* Remove deprecated BalanceUpdater, replace with new methods
This commit is contained in:
Zach Gollwitzer 2025-07-17 06:49:56 -04:00 • committed by GitHub
parent 52333e3fa6
commit 3eea5a9891
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 311 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

23
app/models/balance/base_calculator.rb
View file

@ -20,9 +20,9 @@ class Balance::BaseCalculator
end
def derive_cash_balance_on_date_from_total(total_balance:, date:)
if balance_type == :investment
if account.balance_type == :investment
total_balance - holdings_value_for_date(date)
elsif balance_type == :cash
elsif account.balance_type == :cash
total_balance
else
0
@ -32,7 +32,7 @@ class Balance::BaseCalculator
def derive_cash_balance(cash_balance, date)
entries = sync_cache.get_entries(date)
if balance_type == :non_cash
if account.balance_type == :non_cash
0
else
cash_balance + signed_entry_flows(entries)
@ -42,9 +42,9 @@ class Balance::BaseCalculator
def derive_non_cash_balance(non_cash_balance, date, direction: :forward)
entries = sync_cache.get_entries(date)
# Loans are a special case (loan payment reducing principal, which is non-cash)
if balance_type == :non_cash && account.accountable_type == "Loan"
if account.balance_type == :non_cash && account.accountable_type == "Loan"
non_cash_balance + signed_entry_flows(entries)
elsif balance_type == :investment
elsif account.balance_type == :investment
# For reverse calculations, we need the previous day's holdings
target_date = direction == :forward ? date : date.prev_day
holdings_value_for_date(target_date)
@ -57,19 +57,6 @@ class Balance::BaseCalculator
raise NotImplementedError, "Directional calculators must implement this method"
end
def balance_type
case account.accountable_type
when "Depository", "CreditCard"
:cash
when "Property", "Vehicle", "OtherAsset", "Loan", "OtherLiability"
:non_cash
when "Investment", "Crypto"
:investment
else
raise "Unknown account type: #{account.accountable_type}"
end
end
def build_balance(date:, cash_balance:, non_cash_balance:)
Balance.new(
account_id: account.id,