Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-07 06:25:19 +02:00
Code Issues Releases Activity Actions

Assert flows factor

Browse source
This commit is contained in:
Zach Gollwitzer 2025-07-23 09:43:43 -04:00
parent 27133f665c
commit 4170387aa1
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/models/balance/base_calculator.rb
View file

@ -133,7 +133,8 @@ class Balance::BaseCalculator
non_cash_outflows: args[:non_cash_outflows] || 0, non_cash_outflows: args[:non_cash_outflows] || 0,
cash_adjustments: args[:cash_adjustments] || 0, cash_adjustments: args[:cash_adjustments] || 0,
non_cash_adjustments: args[:non_cash_adjustments] || 0, non_cash_adjustments: args[:non_cash_adjustments] || 0,
net_market_flows: args[:net_market_flows] || 0 net_market_flows: args[:net_market_flows] || 0,
flows_factor: account.classification == "asset" ? 1 : -1
) )
end end
end end

5
test/support/ledger_testing_helper.rb
View file

@ -135,6 +135,11 @@ module LedgerTestingHelper
if expected if expected
assert calculated_balance, "Expected balance for #{date} but none was calculated" assert calculated_balance, "Expected balance for #{date} but none was calculated"
# Always assert flows_factor is correct based on account classification
expected_flows_factor = calculated_balance.account.classification == "asset" ? 1 : -1
assert_equal expected_flows_factor, calculated_balance.flows_factor,
"Flows factor mismatch for #{date}: expected #{expected_flows_factor} for #{calculated_balance.account.classification} account"
legacy_balances = expected[:legacy_balances] legacy_balances = expected[:legacy_balances]
balances = expected[:balances] balances = expected[:balances]
flows = expected[:flows] flows = expected[:flows]