Only update account balance if changed (#1676)

* Only update balance if changed

* Update test assertions

app/models/account.rb

@@ -135,9 +135,11 @@ class Account < ApplicationRecord
   end
 
   def update_with_sync!(attributes)
+    should_update_balance = attributes[:balance] && attributes[:balance].to_d != balance
+
     transaction do
       update!(attributes)
-      update_balance!(attributes[:balance]) if attributes[:balance]
+      update_balance!(attributes[:balance]) if should_update_balance
     end
 
     sync_later

test/interfaces/accountable_resource_interface_test.rb

@@ -61,11 +61,11 @@ module AccountableResourceInterfaceTest
     assert_equal "#{@account.accountable_name.humanize} account created", flash[:notice]
   end
 
-  test "updates account balance by creating new valuation" do
+  test "updates account balance by creating new valuation if balance has changed" do
     assert_difference [ "Account::Entry.count", "Account::Valuation.count" ], 1 do
       patch account_url(@account), params: {
         account: {
-          balance: 10000
+          balance: 12000
         }
       }
     end
@@ -81,7 +81,7 @@ module AccountableResourceInterfaceTest
     assert_no_difference [ "Account::Entry.count", "Account::Valuation.count" ] do
       patch account_url(@account), params: {
         account: {
-          balance: 10000
+          balance: 12000
         }
       }
     end