Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-19 21:29:38 +02:00
Code Issues Releases Activity Actions 1

Fix holding name error (#1113)

Browse source 
* Add optional debugger to bin/dev script

* Fix holding naming
This commit is contained in:
Zach Gollwitzer 2024-08-20 17:35:23 -04:00 • committed by GitHub
parent 37ae51f68a
commit 4433488562
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Procfile.dev
View file

@ -1,3 +1,3 @@
web: bin/rails server -b 0.0.0.0 web: ${DEBUG:+rdbg -O -n -c --} bin/rails server -b 0.0.0.0
css: bin/rails tailwindcss:watch css: bin/rails tailwindcss:watch
worker: bundle exec good_job start worker: bundle exec good_job start

5
app/models/account/holding.rb
View file

@ -14,9 +14,12 @@ class Account::Holding < ApplicationRecord
scope :known_value, -> { where.not(amount: nil) } scope :known_value, -> { where.not(amount: nil) }
scope :for, ->(security) { where(security_id: security).order(:date) } scope :for, ->(security) { where(security_id: security).order(:date) }
delegate :name, to: :security
delegate :ticker, to: :security delegate :ticker, to: :security
def name
security.name || ticker
end
def weight def weight
return nil unless amount return nil unless amount

6
app/views/account/holdings/_holding.html.erb
View file

@ -3,9 +3,11 @@
<%= turbo_frame_tag dom_id(holding) do %> <%= turbo_frame_tag dom_id(holding) do %>
<div class="grid grid-cols-12 items-center text-gray-900 text-sm font-medium p-4"> <div class="grid grid-cols-12 items-center text-gray-900 text-sm font-medium p-4">
<div class="col-span-4 flex items-center gap-4"> <div class="col-span-4 flex items-center gap-4">
<%= render "shared/circle_logo", name: holding.name || "H" %> <%= render "shared/circle_logo", name: holding.name %>
<div class="space-y-0.5"> <div class="space-y-0.5">
<%= link_to holding.name || holding.ticker, account_holding_path(holding.account, holding), data: { turbo_frame: :drawer }, class: "hover:underline" %> <%= link_to holding.name, account_holding_path(holding.account, holding), data: { turbo_frame: :drawer }, class: "hover:underline" %>
<% if holding.amount %> <% if holding.amount %>
<%= tag.p holding.ticker, class: "text-gray-500 text-xs uppercase" %> <%= tag.p holding.ticker, class: "text-gray-500 text-xs uppercase" %>
<% else %> <% else %>