Add nice formatting for subtypes on account list (#2138)

* Add nice formatting for subtypes on account list

* Fix rubocop linting errors

* Implement better mapping

* Fix rubocop linting

* Add short and long versions of subtypes

* Simplify subtype reference

Co-authored-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Signed-off-by: Alex Hatzenbuhler <hatz@hey.com>

* Simplify reference logic, add a small test

* Fix test

* Fix tests

---------

Signed-off-by: Alex Hatzenbuhler <hatz@hey.com>
Co-authored-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>

app/views/accounts/_account.html.erb

@@ -17,6 +17,9 @@
           </p>
         <% else %>
           <%= link_to account.name, account, class: [(account.is_active ? "text-primary" : "text-subdued"), "text-sm font-medium hover:underline"], data: { turbo_frame: "_top" } %>
+          <% if account.long_subtype_label %>
+            <p class="text-sm text-secondary truncate"><%= account.long_subtype_label %></p>
+          <% end %>
         <% end %>
       </div>
 

app/views/accounts/_accountable_group.html.erb

@@ -24,7 +24,7 @@
 
         <div class="min-w-0 grow">
           <%= tag.p account.name, class: "text-sm text-primary font-medium mb-0.5 truncate" %>
-          <%= tag.p account.subtype&.humanize.presence || account_group.name, class: "text-sm text-secondary truncate" %>
+          <%= tag.p account.short_subtype_label, class: "text-sm text-secondary truncate" %>
         </div>
 
         <div class="ml-auto text-right grow h-10">

app/views/depositories/_form.html.erb

@@ -2,6 +2,6 @@
 
 <%= render "accounts/form", account: account, url: url do |form| %>
   <%= form.select :subtype,
-                 Depository::SUBTYPES,
+                 Depository::SUBTYPES.map { |k, v| [v[:long], k] },
                  { label: true, prompt: t("depositories.form.subtype_prompt"), include_blank: t("depositories.form.none") } %>
 <% end %>

app/views/investments/_form.html.erb

@@ -2,6 +2,6 @@
 
 <%= render "accounts/form", account: account, url: url do |form| %>
   <%= form.select :subtype,
-                 Investment::SUBTYPES,
+                 Investment::SUBTYPES.map { |k, v| [v[:long], k] },
                  { label: true, prompt: t("investments.form.subtype_prompt"), include_blank: t("investments.form.none") } %>
 <% end %>

app/views/properties/_form.html.erb

@@ -2,7 +2,7 @@
 
 <%= render "accounts/form", account: account, url: url do |form| %>
   <%= form.select :subtype,
-                 Property::SUBTYPES,
+                 Property::SUBTYPES.map { |k, v| [v[:long], k] },
                  { label: true, prompt: t("properties.form.subtype_prompt"), include_blank: t("properties.form.none") } %>
 
   <hr class="my-4">