Plaid portfolio sync algorithm and calculation improvements (#1526)

* Start tests rework

* Cash balance on schema

* Add reverse syncer

* Reverse balance sync with holdings

* Reverse holdings sync

* Reverse holdings sync should work with only trade entries

* Consolidate brokerage cash

* Add forward sync option

* Update new balance info after syncs

* Intraday balance calculator and sync fixes

* Show only balance for trade entries

* Tests passing

* Update Gemfile.lock

* Cleanup, performance improvements

* Remove account reloads for reliable sync outputs

* Simplify valuation view logic

* Special handling for Plaid cash holding

config/locales/defaults/et.yml

@@ -13,7 +13,7 @@ et:
     - E
     - T
     - K
-    - N
+    - "N"
     - R
     - L
     abbr_month_names:

config/locales/views/account/cashes/en.yml

@@ -1,8 +0,0 @@
----
-en:
-  account:
-    cashes:
-      index:
-        cash: Cash
-        name: Name
-        value: Total Balance

config/locales/views/account/holdings/en.yml

@@ -2,6 +2,8 @@
 en:
   account:
     holdings:
+      cash:
+        brokerage_cash: Brokerage cash
       destroy:
         success: Holding deleted
       holding:

config/locales/views/account/valuations/en.yml

@@ -2,6 +2,8 @@
 en:
   account:
     valuations:
+      valuation:
+        balance_update: Balance update
       form:
         amount: Amount
         submit: Add balance update

config/locales/views/accounts/en.yml

@@ -6,6 +6,8 @@ en:
       troubleshoot: Troubleshoot
     account_list:
       new_account: New %{type}
+    chart:
+      no_change: no change
     create:
       success: "%{type} account created"
     destroy:
@@ -31,8 +33,6 @@ en:
         manual_entry: Enter account balance
         title: How would you like to add it?
       title: What would you like to add?
-    chart:
-      no_change: no change
     show:
       chart:
         balance: Balance

config/locales/views/investments/en.yml

@@ -1,8 +1,6 @@
 ---
 en:
   investments:
-    chart:
-      value: Total value
     edit:
       edit: Edit %{account}
     form:
@@ -15,5 +13,6 @@ en:
     value_tooltip:
       cash: Cash
       holdings: Holdings
-      total_value_tooltip: The total value is the sum of cash balance and your holdings
-        value, minus margin loans.
+      total: Portfolio balance
+      total_value_tooltip: The total portfolio balance is the sum of brokerage cash
+        (available for trading) and the current market value of your holdings.

config/locales/views/settings/en.yml

@@ -39,6 +39,7 @@ en:
         theme_subtitle: Choose a preferred theme for the app (coming soon...)
         theme_system: System
         theme_title: Theme
+        timezone: Timezone
     profiles:
       show:
         confirm_delete:

config/locales/views/shared/en.yml

@@ -1,8 +1,6 @@
 ---
 en:
   shared:
-    syncing_notice:
-      syncing: Syncing accounts data...
     confirm_modal:
       accept: Confirm
       body_html: "<p>You will not be able to undo this decision</p>"
@@ -15,6 +13,8 @@ en:
       no_account_subtitle: Since no accounts have been added, there's no data to display.
         Add your first accounts to start viewing dashboard data.
       no_account_title: No accounts yet
+    syncing_notice:
+      syncing: Syncing accounts data...
     upgrade_notification:
       app_upgraded: The app has been upgraded to %{version}.
       dismiss: Dismiss

config/routes.rb

@@ -75,7 +75,6 @@ Rails.application.routes.draw do
 
   namespace :account do
     resources :holdings, only: %i[index new show destroy]
-    resources :cashes, only: :index
 
     resources :entries, only: :index