Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-04 13:05:19 +02:00
Code Issues Releases Activity Actions

Add scope to filter transactions from active accounts (#1810)

Browse source 
* Add scope to filter transactions from active accounts

* Add test for transfer match candidates with active accounts

* Refactor active account filtering for transactions and entries
This commit is contained in:
Josh Pigford 2025-02-05 11:52:44 -06:00 • committed by GitHub
parent cf014bc24f
commit 4aba9d1c0b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 69 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/transactions_controller.rb
View file

@ -7,7 +7,7 @@ class TransactionsController < ApplicationController
def index
@q = search_params
search_query = Current.family.transactions.search(@q)
search_query = Current.family.transactions.search(@q).active
set_focused_record(search_query, params[:focused_record_id], default_per_page: 50)

2
app/models/account.rb
View file

@ -184,6 +184,8 @@ class Account < ApplicationRecord
.joins("JOIN accounts inflow_accounts ON inflow_accounts.id = inflow_candidates.account_id")
.joins("JOIN accounts outflow_accounts ON outflow_accounts.id = outflow_candidates.account_id")
.where("inflow_accounts.family_id = ? AND outflow_accounts.family_id = ?", self.family_id, self.family_id)
.where("inflow_accounts.is_active = true AND inflow_accounts.scheduled_for_deletion = false")
.where("outflow_accounts.is_active = true AND outflow_accounts.scheduled_for_deletion = false")
.where("inflow_candidates.entryable_type = 'Account::Transaction' AND outflow_candidates.entryable_type = 'Account::Transaction'")
.where(existing_transfers: { id: nil })
.order("date_diff ASC") # Closest matches first

4
app/models/account/entry.rb
View file

@ -24,6 +24,10 @@ class Account::Entry < ApplicationRecord
)
}
scope :active, -> {
joins(:account).where(accounts: { is_active: true, scheduled_for_deletion: false })
}
scope :reverse_chronological, -> {
order(
date: :desc,