1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-23 07:09:39 +02:00

Add scope to filter transactions from active accounts (#1810)

* Add scope to filter transactions from active accounts

* Add test for transfer match candidates with active accounts

* Refactor active account filtering for transactions and entries
This commit is contained in:
Josh Pigford 2025-02-05 11:52:44 -06:00 committed by GitHub
parent cf014bc24f
commit 4aba9d1c0b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 69 additions and 1 deletions

View file

@ -99,4 +99,43 @@ class AccountTest < ActiveSupport::TestCase
@account.auto_match_transfers!
end
end
test "transfer_match_candidates only matches between active accounts" do
active_account = accounts(:depository)
another_active_account = accounts(:credit_card)
inactive_account = accounts(:investment)
inactive_account.update!(is_active: false)
# Create matching transactions
active_inflow = active_account.entries.create!(
date: Date.current,
amount: -100,
currency: "USD",
name: "Test transfer",
entryable: Account::Transaction.new
)
active_outflow = another_active_account.entries.create!(
date: Date.current,
amount: 100,
currency: "USD",
name: "Test transfer",
entryable: Account::Transaction.new
)
inactive_outflow = inactive_account.entries.create!(
date: Date.current,
amount: 100,
currency: "USD",
name: "Test transfer",
entryable: Account::Transaction.new
)
# Should find matches between active accounts
candidates = active_account.transfer_match_candidates
assert_includes candidates.map(&:outflow_transaction_id), active_outflow.entryable_id
# Should not match with inactive account
assert_not_includes candidates.map(&:outflow_transaction_id), inactive_outflow.entryable_id
end
end