Basic trade and holdings view (#1271)

* Add trade view

* Lint fix

* Fix stale placeholder variable

* Add holding view

app/controllers/account/entries_controller.rb

@@ -25,7 +25,7 @@ class Account::EntriesController < ApplicationController
   def destroy
     @entry.destroy!
     @entry.sync_account_later
-    redirect_back_or_to account_url(@entry.account), notice: t(".success")
+    redirect_to account_url(@entry.account), notice: t(".success")
   end
 
   private

app/controllers/account/holdings_controller.rb

@@ -2,7 +2,7 @@ class Account::HoldingsController < ApplicationController
   layout :with_sidebar
 
   before_action :set_account
-  before_action :set_holding, only: :show
+  before_action :set_holding, only: %i[show destroy]
 
   def index
     @holdings = @account.holdings.current
@@ -11,6 +11,11 @@ class Account::HoldingsController < ApplicationController
   def show
   end
 
+  def destroy
+    @holding.destroy_holding_and_entries!
+    redirect_back_or_to account_holdings_path(@account)
+  end
+
   private
 
     def set_account

app/controllers/account/trades_controller.rb

@@ -2,6 +2,7 @@ class Account::TradesController < ApplicationController
   layout :with_sidebar
 
   before_action :set_account
+  before_action :set_entry, only: :update
 
   def new
     @entry = @account.entries.account_trades.new(entryable_attributes: {})
@@ -23,15 +24,36 @@ class Account::TradesController < ApplicationController
     end
   end
 
+  def update
+    @entry.update!(entry_params)
+
+    respond_to do |format|
+      format.html { redirect_to account_entry_path(@account, @entry), notice: t(".success") }
+      format.turbo_stream { render turbo_stream: turbo_stream.replace(@entry) }
+    end
+  end
+
   private
 
     def set_account
       @account = Current.family.accounts.find(params[:account_id])
     end
 
+    def set_entry
+      @entry = @account.entries.find(params[:id])
+    end
+
     def entry_params
       params.require(:account_entry)
-            .permit(:type, :date, :qty, :ticker, :price, :amount, :currency, :transfer_account_id)
+            .permit(
+              :type, :date, :qty, :ticker, :price, :amount, :notes, :excluded, :currency, :transfer_account_id, :entryable_type,
+              entryable_attributes: [
+                :id,
+                :qty,
+                :ticker,
+                :price
+              ]
+            )
             .merge(account: @account)
     end
 end

app/controllers/account/transactions_controller.rb

@@ -33,11 +33,9 @@ class Account::TransactionsController < ApplicationController
     def entry_params
       params.require(:account_entry)
             .permit(
-              :name, :date, :amount, :currency, :entryable_type, :nature,
+              :name, :date, :amount, :currency, :excluded, :notes, :entryable_type, :nature,
               entryable_attributes: [
                 :id,
-                :notes,
-                :excluded,
                 :category_id,
                 :merchant_id,
                 { tag_ids: [] }