Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-23 15:19:38 +02:00
Code Issues Releases Activity Actions

Implement transaction category management (#688)

Browse source 
* Singularize "transaction" in transaction-nested paths

* Refactor category badge partial

* Let modal content define its width

* Add contectual menu to transactions index

* Add null_category helper

* Implement category edits

* Fix inline transaction category badges

* Fix typos in system test paths

* Add missing translations

* Add decoration to color select controller

* Wire up transaction category creation

* Fix indent in color-select-controller

* Add button for clearing category from transaction

* Implement category deletions

* Fix existing modal sizes

* Use null_category in a single place

* Remove anemic method in category deletion controller

* reassign_and_destroy -> reassign_transactions_then_destroy

* Fix i18n

* Remove destroy action from CategoriesController callbacks

* transactions_merchant -> transaction_merchant

* reassign_transactions_then_destroy -> replace_and_destroy

* Add transaction category CRUD tests

* Add presence check for transaction_id

* Check replacement_category_id presence

* Test Transaction::Category#replace_and_destroy!
This commit is contained in:
Jose Farias 2024-05-02 07:24:31 -06:00 • committed by GitHub
parent dc024d63b0
commit 4c5f8263bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
40 changed files with 580 additions and 145 deletions
Download patch file Download diff file Expand all files Collapse all files

48
app/controllers/transactions/categories_controller.rb
View file

@ -1,37 +1,45 @@
class Transactions::CategoriesController < ApplicationController
before_action :set_category, only: [ :update, :destroy ]
before_action :set_category, only: %i[ edit update ]
before_action :set_transaction, only: :create
def index
@categories = Current.family.transaction_categories.alphabetically
end
def new
@category = Current.family.transaction_categories.new color: Transaction::Category::COLORS.sample
end
def create
if Current.family.transaction_categories.create(category_params)
redirect_to transactions_path, notice: t(".success")
else
render transactions_path, status: :unprocessable_entity, notice: t(".error")
Transaction::Category.transaction do
category = Current.family.transaction_categories.create!(category_params)
@transaction.update!(category_id: category.id) if @transaction
end
redirect_back_or_to transactions_path, notice: t(".success")
end
def edit
end
def update
if @category.update(category_params)
redirect_to transactions_path, notice: t(".success")
else
render transactions_path, status: :unprocessable_entity, notice: t(".error")
end
end
@category.update! category_params
def destroy
@category.destroy!
redirect_to transactions_path, notice: t(".success")
redirect_back_or_to transactions_path, notice: t(".success")
end
private
def set_category
@category = Current.family.transaction_categories.find(params[:id])
end
def set_category
@category = Current.family.transaction_categories.find(params[:id])
end
def set_transaction
if params[:transaction_id].present?
@transaction = Current.family.transactions.find(params[:transaction_id])
end
end
def category_params
params.require(:transaction_category).permit(:name, :color)
end
def category_params
params.require(:transaction_category).permit(:name, :color)
end
end