Implement transaction category management (#688)

* Singularize "transaction" in transaction-nested paths

* Refactor category badge partial

* Let modal content define its width

* Add contectual menu to transactions index

* Add null_category helper

* Implement category edits

* Fix inline transaction category badges

* Fix typos in system test paths

* Add missing translations

* Add decoration to color select controller

* Wire up transaction category creation

* Fix indent in color-select-controller

* Add button for clearing category from transaction

* Implement category deletions

* Fix existing modal sizes

* Use null_category in a single place

* Remove anemic method in category deletion controller

* reassign_and_destroy -> reassign_transactions_then_destroy

* Fix i18n

* Remove destroy action from CategoriesController callbacks

* transactions_merchant -> transaction_merchant

* reassign_transactions_then_destroy -> replace_and_destroy

* Add transaction category CRUD tests

* Add presence check for transaction_id

* Check replacement_category_id presence

* Test Transaction::Category#replace_and_destroy!

test/controllers/transactions/categories/deletions_controller_test.rb

@@ -0,0 +1,40 @@
+require "test_helper"
+
+class Transactions::Categories::DeletionsControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in users(:family_admin)
+    @category = transaction_categories(:food_and_drink)
+  end
+
+  test "new" do
+    get new_transaction_category_deletion_url(@category)
+    assert_response :success
+  end
+
+  test "create with replacement" do
+    replacement_category = transaction_categories(:income)
+
+    assert_not_empty @category.transactions
+
+    assert_difference "Transaction::Category.count", -1 do
+      assert_difference "replacement_category.transactions.count", @category.transactions.count do
+        post transaction_category_deletions_url(@category),
+          params: { replacement_category_id: replacement_category.id }
+      end
+    end
+
+    assert_redirected_to transactions_url
+  end
+
+  test "create without replacement" do
+    assert_not_empty @category.transactions
+
+    assert_difference "Transaction::Category.count", -1 do
+      assert_difference "Transaction.where(category: nil).count", @category.transactions.count do
+        post transaction_category_deletions_url(@category)
+      end
+    end
+
+    assert_redirected_to transactions_url
+  end
+end

test/controllers/transactions/categories_controller_test.rb

@@ -1,7 +1,73 @@
 require "test_helper"
 
 class Transactions::CategoriesControllerTest < ActionDispatch::IntegrationTest
-  # test "the truth" do
-  #   assert true
-  # end
+  setup do
+    sign_in users(:family_admin)
+  end
+
+  test "index" do
+    get transaction_categories_url
+    assert_response :success
+  end
+
+  test "new" do
+    get new_transaction_category_url
+    assert_response :success
+  end
+
+  test "create" do
+    color = Transaction::Category::COLORS.sample
+
+    assert_difference "Transaction::Category.count", +1 do
+      post transaction_categories_url, params: {
+        transaction_category: {
+          name: "New Category",
+          color: color } }
+    end
+
+    new_category = Transaction::Category.order(:created_at).last
+
+    assert_redirected_to transactions_url
+    assert_equal "New Category", new_category.name
+    assert_equal color, new_category.color
+  end
+
+  test "create and assign to transaction" do
+    color = Transaction::Category::COLORS.sample
+
+    assert_difference "Transaction::Category.count", +1 do
+      post transaction_categories_url, params: {
+        transaction_id: transactions(:checking_one).id,
+        transaction_category: {
+          name: "New Category",
+          color: color } }
+    end
+
+    new_category = Transaction::Category.order(:created_at).last
+
+    assert_redirected_to transactions_url
+    assert_equal "New Category", new_category.name
+    assert_equal color, new_category.color
+    assert_equal transactions(:checking_one).reload.category, new_category
+  end
+
+  test "edit" do
+    get edit_transaction_category_url(transaction_categories(:food_and_drink))
+    assert_response :success
+  end
+
+  test "update" do
+    new_color = Transaction::Category::COLORS.without(transaction_categories(:income).color).sample
+
+    assert_changes -> { transaction_categories(:income).name }, to: "New Name" do
+      assert_changes -> { transaction_categories(:income).reload.color }, to: new_color do
+        patch transaction_category_url(transaction_categories(:income)), params: {
+          transaction_category: {
+            name: "New Name",
+            color: new_color } }
+      end
+    end
+
+    assert_redirected_to transactions_url
+  end
 end

test/controllers/transactions/merchants_controller_test.rb

@@ -7,33 +7,33 @@ class Transactions::MerchantsControllerTest < ActionDispatch::IntegrationTest
   end
 
   test "index" do
-    get transactions_merchants_path
+    get transaction_merchants_path
     assert_response :success
   end
 
   test "new" do
-    get new_transactions_merchant_path
+    get new_transaction_merchant_path
     assert_response :success
   end
 
   test "should create merchant" do
     assert_difference("Transaction::Merchant.count") do
-      post transactions_merchants_url, params: { transaction_merchant: { name: "new merchant", color: "#000000" } }
+      post transaction_merchants_url, params: { transaction_merchant: { name: "new merchant", color: "#000000" } }
     end
 
-    assert_redirected_to transactions_merchants_path
+    assert_redirected_to transaction_merchants_path
   end
 
   test "should update merchant" do
-    patch transactions_merchant_url(@merchant), params: { transaction_merchant: { name: "new name", color: "#000000" } }
-    assert_redirected_to transactions_merchants_path
+    patch transaction_merchant_url(@merchant), params: { transaction_merchant: { name: "new name", color: "#000000" } }
+    assert_redirected_to transaction_merchants_path
   end
 
   test "should destroy merchant" do
     assert_difference("Transaction::Merchant.count", -1) do
-      delete transactions_merchant_url(@merchant)
+      delete transaction_merchant_url(@merchant)
     end
 
-    assert_redirected_to transactions_merchants_path
+    assert_redirected_to transaction_merchants_path
   end
 end