Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-23 15:19:38 +02:00
Code Issues Releases Activity Actions

Handle duplicate sync jobs

Browse source
This commit is contained in:
Zach Gollwitzer 2025-05-24 17:58:17 -04:00
parent aecb5aafd8
commit 5125411822
2 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/models/sync.rb
View file

@ -57,6 +57,12 @@ class Sync < ApplicationRecord
def perform def perform
Rails.logger.tagged("Sync", id, syncable_type, syncable_id) do Rails.logger.tagged("Sync", id, syncable_type, syncable_id) do
# This can happen on server restarts or if Sidekiq enqueues a duplicate job
unless may_start?
Rails.logger.warn("Sync #{id} is not in a valid state (#{aasm.from_state}) to start. Skipping sync.")
return
end
start! start!
begin begin

11
test/models/sync_test.rb
View file

@ -3,6 +3,17 @@ require "test_helper"
class SyncTest < ActiveSupport::TestCase class SyncTest < ActiveSupport::TestCase
include ActiveJob::TestHelper include ActiveJob::TestHelper
test "does not run if not in a valid state" do
syncable = accounts(:depository)
sync = Sync.create!(syncable: syncable, status: :completed)
syncable.expects(:perform_sync).never
sync.perform
assert_equal "completed", sync.status
end
test "runs successful sync" do test "runs successful sync" do
syncable = accounts(:depository) syncable = accounts(:depository)
sync = Sync.create!(syncable: syncable) sync = Sync.create!(syncable: syncable)