Test environment stability improvements (#703)

* Add climate_control gem and test helper

* Replace ENV mods in upgrades test

* Replace ENV mods in registrations test

* Remove ENV references in hostings controller

* Update ENV refs in mailer test

* ActiveStorage cleanup

* Consolidate queue config so appropriate adapter runs in test environment

* Make test environment more explicit

* Centralize self hosting config

* Remove flaky system test

config/application.rb

@@ -25,5 +25,9 @@ module Maybe
     # config.eager_load_paths << Rails.root.join("extras")
 
     config.action_mailer.default_options = { from: ENV["MAILER_SENDER"] }
+
+    config.active_job.queue_adapter = :good_job
+
+    config.app_mode = (ENV["SELF_HOSTING_ENABLED"] == "true" ? "self_hosted" : "managed").inquiry
   end
 end

config/environments/development.rb

@@ -76,10 +76,6 @@ Rails.application.configure do
   # Highlight code that enqueued background job in logs.
   config.active_job.verbose_enqueue_logs = true
 
-  # Set Active Job queue adapter
-  config.active_job.queue_adapter = :good_job
-
-
   # Raises error for missing translations.
   # config.i18n.raise_on_missing_translations = true
 

config/environments/production.rb

@@ -61,10 +61,6 @@ Rails.application.configure do
   # Use a different cache store in production.
   # config.cache_store = :mem_cache_store
 
-  # Use a real queuing backend for Active Job (and separate queues per environment).
-  config.active_job.queue_adapter = :good_job
-  # config.active_job.queue_name_prefix = "maybe_production"
-
   config.action_mailer.perform_caching = false
 
   config.action_mailer.default_url_options = { host: ENV["APP_DOMAIN"] }

config/storage.yml

@@ -12,14 +12,16 @@ amazon:
   secret_access_key: <%= ENV["S3_SECRET_ACCESS_KEY"] %>
   region: <%= ENV["S3_REGION"] || "us-east-1" %>
   bucket: <%= ENV["S3_BUCKET"] %>
-google:
-  service: GCS
-  project: <%= ENV["GCS_PROJECT"] %>
-  credentials: <%= Rails.root.join("gcp-storage-keyfile.json") %>
-  bucket: <%= ENV["GCS_BUCKET"] %> 
 
-azure:
-  service: AzureStorage
-  storage_account_name: <%= ENV["AZURE_STORAGE_ACCOUNT_NAME"] %>
-  storage_access_key: <%= ENV["AZURE_STORAGE_ACCESS_KEY"] %>
-  container: <%= ENV["AZURE_STORAGE_CONTAINER"] %> 
+# Removed in #702.  Uncomment, add gems, update .env.example to enable.
+#google:
+#  service: GCS
+#  project: <%#= ENV["GCS_PROJECT"] %>
+#  credentials: <%#= Rails.root.join("gcp-storage-keyfile.json") %>
+#  bucket: <%#= ENV["GCS_BUCKET"] %>
+
+#azure:
+#  service: AzureStorage
+#  storage_account_name: <%#= ENV["AZURE_STORAGE_ACCOUNT_NAME"] %>
+#  storage_access_key: <%#= ENV["AZURE_STORAGE_ACCESS_KEY"] %>
+#  container: <%#= ENV["AZURE_STORAGE_CONTAINER"] %>