From 6254ea9d8a52dc581f3766c3825a05fe4f0b586d Mon Sep 17 00:00:00 2001 From: Konnor Rogers Date: Thu, 8 Feb 2024 14:37:36 -0500 Subject: [PATCH] Prevent duplicate listeners and memory leak (#387) * Prevent duplicate listeners and memory leak Signed-off-by: Konnor Rogers * Update dropdown_controller.js Signed-off-by: Konnor Rogers --------- Signed-off-by: Konnor Rogers --- app/javascript/controllers/dropdown_controller.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/javascript/controllers/dropdown_controller.js b/app/javascript/controllers/dropdown_controller.js index c633a5d5..610455a0 100644 --- a/app/javascript/controllers/dropdown_controller.js +++ b/app/javascript/controllers/dropdown_controller.js @@ -9,15 +9,15 @@ export default class extends Controller { this.menuTarget.classList.toggle("hidden"); } - hideMenu() { + hideMenu = () => { this.menuTarget.classList.add("hidden"); } connect() { - document.addEventListener("click", () => this.hideMenu()); + document.addEventListener("click", this.hideMenu); } disconnect() { - document.removeEventListener("click", () => this.hideMenu()); + document.removeEventListener("click", this.hideMenu); } -} \ No newline at end of file +}