Handle missing exchange rate provider, allow fallback for missing rates (#955)

* Clean up exchange rate logic

* Remove stale method

test/models/account/balance/calculator_test.rb

@@ -25,6 +25,17 @@ class Account::Balance::CalculatorTest < ActiveSupport::TestCase
   end
 
   test "syncs foreign checking account balances" do
+    required_exchange_rates_for_sync = [
+      1.0834, 1.0845, 1.0819, 1.0872, 1.0788, 1.0743, 1.0755, 1.0774,
+      1.0778, 1.0783, 1.0773, 1.0709, 1.0729, 1.0773, 1.0778, 1.078,
+      1.0809, 1.0818, 1.0824, 1.0822, 1.0854, 1.0845, 1.0839, 1.0807,
+      1.084, 1.0856, 1.0858, 1.0898, 1.095, 1.094, 1.0926, 1.0986
+    ]
+
+    required_exchange_rates_for_sync.each_with_index do |exchange_rate, idx|
+      ExchangeRate.create! date: idx.days.ago.to_date, from_currency: "EUR", to_currency: "USD", rate: exchange_rate
+    end
+
     # Foreign accounts will generate balances for all currencies
     expected_usd_balances = get_expected_balances_for(:eur_checking_usd)
     expected_eur_balances = get_expected_balances_for(:eur_checking_eur)
@@ -38,6 +49,13 @@ class Account::Balance::CalculatorTest < ActiveSupport::TestCase
   end
 
   test "syncs multi-currency checking account balances" do
+    required_exchange_rates_for_sync = [
+      { from_currency: "EUR", to_currency: "USD", date: 4.days.ago.to_date, rate: 1.0788 },
+      { from_currency: "EUR", to_currency: "USD", date: 19.days.ago.to_date, rate: 1.0822 }
+    ]
+
+    ExchangeRate.insert_all(required_exchange_rates_for_sync)
+
     expected_balances = get_expected_balances_for(:multi_currency)
     assert_account_balances calculated_balances_for(:multi_currency), expected_balances
   end

test/models/account/syncable_test.rb

@@ -18,15 +18,14 @@ class Account::SyncableTest < ActiveSupport::TestCase
     assert_equal 32, @account.balances.count
   end
 
-  test "syncs foreign currency account" do
-    account = accounts(:eur_checking)
-    account.sync
-    assert_equal "ok", account.status
-    assert_equal 32, account.balances.where(currency: "USD").count
-    assert_equal 32, account.balances.where(currency: "EUR").count
-  end
-
   test "syncs multi currency account" do
+    required_exchange_rates_for_sync = [
+      { from_currency: "EUR", to_currency: "USD", date: 4.days.ago.to_date, rate: 1.0788 },
+      { from_currency: "EUR", to_currency: "USD", date: 19.days.ago.to_date, rate: 1.0822 }
+    ]
+
+    ExchangeRate.insert_all(required_exchange_rates_for_sync)
+
     account = accounts(:multi_currency)
     account.sync
     assert_equal "ok", account.status
@@ -91,6 +90,17 @@ class Account::SyncableTest < ActiveSupport::TestCase
   end
 
   test "foreign currency account has balances in each currency after syncing" do
+    required_exchange_rates_for_sync = [
+      1.0834, 1.0845, 1.0819, 1.0872, 1.0788, 1.0743, 1.0755, 1.0774,
+      1.0778, 1.0783, 1.0773, 1.0709, 1.0729, 1.0773, 1.0778, 1.078,
+      1.0809, 1.0818, 1.0824, 1.0822, 1.0854, 1.0845, 1.0839, 1.0807,
+      1.084, 1.0856, 1.0858, 1.0898, 1.095, 1.094, 1.0926, 1.0986
+    ]
+
+    required_exchange_rates_for_sync.each_with_index do |exchange_rate, idx|
+      ExchangeRate.create! date: idx.days.ago.to_date, from_currency: "EUR", to_currency: "USD", rate: exchange_rate
+    end
+
     account = accounts(:eur_checking)
     account.sync
 

test/models/exchange_rate_test.rb

@@ -1,50 +1,95 @@
 require "test_helper"
 require "ostruct"
+
 class ExchangeRateTest < ActiveSupport::TestCase
-  test "find rate in db" do
-    assert_equal exchange_rates(:day_29_ago_eur_to_usd),
-      ExchangeRate.find_rate_or_fetch(from: "EUR", to: "USD", date: 29.days.ago.to_date)
+  setup do
+    @provider = mock
+
+    ExchangeRate.stubs(:exchange_rates_provider).returns(@provider)
   end
 
-  test "fetch rate from provider when it's not found in db" do
-    with_env_overrides SYNTH_API_KEY: "true" do
-      ExchangeRate
-        .expects(:fetch_rate_from_provider)
-        .returns(ExchangeRate.new(base_currency: "USD", converted_currency: "MXN", rate: 1.0, date: Date.current))
+  test "exchange rate provider nil if no api key configured" do
+    ExchangeRate.unstub(:exchange_rates_provider)
 
-      ExchangeRate.find_rate_or_fetch from: "USD", to: "MXN", date: Date.current
+    with_env_overrides SYNTH_API_KEY: nil do
+      assert_nil ExchangeRate.exchange_rates_provider
     end
   end
 
-  test "provided rates are saved to the db" do
-    with_env_overrides SYNTH_API_KEY: "true" do
-      VCR.use_cassette "synth_exchange_rate" do
-        assert_difference "ExchangeRate.count", 1 do
-          ExchangeRate.find_rate_or_fetch from: "USD", to: "MXN", date: Date.current
-        end
-      end
+  test "finds single rate in DB" do
+    @provider.expects(:fetch_exchange_rate).never
+
+    rate = exchange_rates(:one)
+
+    assert_equal exchange_rates(:one), ExchangeRate.find_rate(from: rate.from_currency, to: rate.to_currency, date: rate.date)
+  end
+
+  test "finds single rate from provider and caches to DB" do
+    expected_rate = 1.21
+    @provider.expects(:fetch_exchange_rate).once.returns(OpenStruct.new(success?: true, rate: expected_rate))
+
+    fetched_rate = ExchangeRate.find_rate(from: "USD", to: "EUR", date: Date.current, cache: true)
+    refetched_rate = ExchangeRate.find_rate(from: "USD", to: "EUR", date: Date.current, cache: true)
+
+    assert_equal expected_rate, fetched_rate.rate
+    assert_equal expected_rate, refetched_rate.rate
+  end
+
+  test "nil if rate is not found in DB and provider throws an error" do
+    @provider.expects(:fetch_exchange_rate).with(from: "USD", to: "EUR", date: Date.current).once.returns(OpenStruct.new(success?: false))
+
+    assert_nil ExchangeRate.find_rate(from: "USD", to: "EUR", date: Date.current)
+  end
+
+  test "nil if rate is not found in DB and provider is disabled" do
+    ExchangeRate.unstub(:exchange_rates_provider)
+
+    with_env_overrides SYNTH_API_KEY: nil do
+      assert_nil ExchangeRate.find_rate(from: "USD", to: "EUR", date: Date.current)
     end
   end
 
-  test "retrying, then raising on provider error" do
-    with_env_overrides SYNTH_API_KEY: "true" do
-      Faraday.expects(:get).returns(OpenStruct.new(success?: false)).times(3)
+  test "finds multiple rates in DB" do
+    @provider.expects(:fetch_exchange_rate).never
 
-      error = assert_raises Provider::Base::ProviderError do
-        ExchangeRate.find_rate_or_fetch from: "USD", to: "MXN", date: Date.current
-      end
+    rate1 = exchange_rates(:one) # EUR -> GBP, today
+    rate2 = exchange_rates(:two) # EUR -> GBP, yesterday
 
-      assert_match "Failed to fetch exchange rate from Provider::Synth", error.message
-    end
+    fetched_rates = ExchangeRate.find_rates(from: rate1.from_currency, to: rate1.to_currency, start_date: 1.day.ago.to_date).sort_by(&:date)
+
+    assert_equal rate1, fetched_rates[1]
+    assert_equal rate2, fetched_rates[0]
   end
 
-  test "retrying, then raising on network error" do
-    with_env_overrides SYNTH_API_KEY: "true" do
-      Faraday.expects(:get).raises(Faraday::TimeoutError).times(3)
+  test "finds multiple rates from provider and caches to DB" do
+    @provider.expects(:fetch_exchange_rate).with(from: "EUR", to: "USD", date: 1.day.ago.to_date).returns(OpenStruct.new(success?: true, rate: 1.1)).once
+    @provider.expects(:fetch_exchange_rate).with(from: "EUR", to: "USD", date: Date.current).returns(OpenStruct.new(success?: true, rate: 1.2)).once
 
-      assert_raises Faraday::TimeoutError do
-        ExchangeRate.find_rate_or_fetch from: "USD", to: "MXN", date: Date.current
-      end
+    fetched_rates = ExchangeRate.find_rates(from: "EUR", to: "USD", start_date: 1.day.ago.to_date, cache: true)
+    refetched_rates = ExchangeRate.find_rates(from: "EUR", to: "USD", start_date: 1.day.ago.to_date)
+
+    assert_equal [ 1.1, 1.2 ], fetched_rates.sort_by(&:date).map(&:rate)
+    assert_equal [ 1.1, 1.2 ], refetched_rates.sort_by(&:date).map(&:rate)
+  end
+
+  test "finds missing db rates from provider and appends to results" do
+    @provider.expects(:fetch_exchange_rate).with(from: "EUR", to: "GBP", date: 2.days.ago.to_date).returns(OpenStruct.new(success?: true, rate: 1.1)).once
+
+    rate1 = exchange_rates(:one) # EUR -> GBP, today
+    rate2 = exchange_rates(:two) # EUR -> GBP, yesterday
+
+    fetched_rates = ExchangeRate.find_rates(from: "EUR", to: "GBP", start_date: 2.days.ago.to_date, cache: true)
+    refetched_rates = ExchangeRate.find_rates(from: "EUR", to: "GBP", start_date: 2.days.ago.to_date)
+
+    assert_equal [ 1.1, rate2.rate, rate1.rate ], fetched_rates.sort_by(&:date).map(&:rate)
+    assert_equal [ 1.1, rate2.rate, rate1.rate ], refetched_rates.sort_by(&:date).map(&:rate)
+  end
+
+  test "returns empty array if no rates found in DB or provider" do
+    ExchangeRate.unstub(:exchange_rates_provider)
+
+    with_env_overrides SYNTH_API_KEY: nil do
+      assert_equal [], ExchangeRate.find_rates(from: "USD", to: "JPY", start_date: 10.days.ago.to_date)
     end
   end
 end

test/models/family_test.rb

@@ -6,6 +6,18 @@ class FamilyTest < ActiveSupport::TestCase
 
   def setup
     @family = families(:dylan_family)
+
+    required_exchange_rates_for_family = [
+      1.0834, 1.0845, 1.0819, 1.0872, 1.0788, 1.0743, 1.0755, 1.0774,
+      1.0778, 1.0783, 1.0773, 1.0709, 1.0729, 1.0773, 1.0778, 1.078,
+      1.0809, 1.0818, 1.0824, 1.0822, 1.0854, 1.0845, 1.0839, 1.0807,
+      1.084, 1.0856, 1.0858, 1.0898, 1.095, 1.094, 1.0926, 1.0986
+    ]
+
+    required_exchange_rates_for_family.each_with_index do |exchange_rate, idx|
+      ExchangeRate.create! date: idx.days.ago.to_date, from_currency: "EUR", to_currency: "USD", rate: exchange_rate
+    end
+
     @family.accounts.each do |account|
       account.sync
     end

test/models/provider/synth_test.rb

@@ -1,9 +1,26 @@
 require "test_helper"
+require "ostruct"
 
 class Provider::SynthTest < ActiveSupport::TestCase
   include ExchangeRateProviderInterfaceTest
 
   setup do
-    @subject = Provider::Synth.new
+    @subject = @synth = Provider::Synth.new("fookey")
+  end
+
+  test "retries then provides failed response" do
+    Faraday.expects(:get).returns(OpenStruct.new(success?: false)).times(3)
+
+    response = @synth.fetch_exchange_rate from: "USD", to: "MXN", date: Date.current
+
+    assert_match "Failed to fetch exchange rate from Provider::Synth", response.error.message
+  end
+
+  test "retrying, then raising on network error" do
+    Faraday.expects(:get).raises(Faraday::TimeoutError).times(3)
+
+    assert_raises Faraday::TimeoutError do
+      @synth.fetch_exchange_rate from: "USD", to: "MXN", date: Date.current
+    end
   end
 end