Only fetch needed Plaid products, improve Plaid tests and mocks

test/models/plaid_account/importer_test.rb

@@ -2,34 +2,45 @@ require "test_helper"
 
 class PlaidAccount::ImporterTest < ActiveSupport::TestCase
   setup do
-    @mock_provider = PlaidMock.new
     @plaid_account = plaid_accounts(:one)
-    @plaid_item = @plaid_account.plaid_item
-
-    @accounts_snapshot = PlaidItem::AccountsSnapshot.new(@plaid_item, plaid_provider: @mock_provider)
-    @account_snapshot = @accounts_snapshot.get_account_data(@plaid_account.plaid_id)
+    @mock_account_snapshot = mock
   end
 
   test "imports account data" do
-    PlaidAccount::Importer.new(@plaid_account, account_snapshot: @account_snapshot).import
+    account_data = OpenStruct.new(
+      account_id: "acc_1",
+      name: "Test Account",
+      mask: "1234",
+    )
 
-    assert_equal @account_snapshot.account_data.account_id, @plaid_account.plaid_id
-    assert_equal @account_snapshot.account_data.name, @plaid_account.name
-    assert_equal @account_snapshot.account_data.mask, @plaid_account.mask
-    assert_equal @account_snapshot.account_data.type, @plaid_account.plaid_type
-    assert_equal @account_snapshot.account_data.subtype, @plaid_account.plaid_subtype
+    transactions_data = OpenStruct.new(
+      added: [],
+      modified: [],
+      removed: [],
+    )
 
-    # This account has transactions data
-    assert_equal PlaidMock::TRANSACTIONS.count, @plaid_account.raw_transactions_payload["added"].count
+    investments_data = OpenStruct.new(
+      holdings: [],
+      transactions: [],
+      securities: [],
+    )
 
-    # This account does not have investment data
-    assert_equal 0, @plaid_account.raw_investments_payload["holdings"].count
-    assert_equal 0, @plaid_account.raw_investments_payload["securities"].count
-    assert_equal 0, @plaid_account.raw_investments_payload["transactions"].count
+    liabilities_data = OpenStruct.new(
+      credit: [],
+      mortgage: [],
+      student: [],
+    )
 
-    # This account is a credit card, so it should have liability data
-    assert_equal @plaid_account.plaid_id, @plaid_account.raw_liabilities_payload["credit"]["account_id"]
-    assert_nil @plaid_account.raw_liabilities_payload["mortgage"]
-    assert_nil @plaid_account.raw_liabilities_payload["student"]
+    @mock_account_snapshot.expects(:account_data).returns(account_data).at_least_once
+    @mock_account_snapshot.expects(:transactions_data).returns(transactions_data).at_least_once
+    @mock_account_snapshot.expects(:investments_data).returns(investments_data).at_least_once
+    @mock_account_snapshot.expects(:liabilities_data).returns(liabilities_data).at_least_once
+
+    @plaid_account.expects(:upsert_plaid_snapshot!).with(account_data)
+    @plaid_account.expects(:upsert_plaid_transactions_snapshot!).with(transactions_data)
+    @plaid_account.expects(:upsert_plaid_investments_snapshot!).with(investments_data)
+    @plaid_account.expects(:upsert_plaid_liabilities_snapshot!).with(liabilities_data)
+
+    PlaidAccount::Importer.new(@plaid_account, account_snapshot: @mock_account_snapshot).import
   end
 end

test/models/plaid_item/accounts_snapshot_test.rb

@@ -0,0 +1,105 @@
+require "test_helper"
+
+class PlaidItem::AccountsSnapshotTest < ActiveSupport::TestCase
+  setup do
+    @plaid_item = plaid_items(:one)
+    @plaid_item.plaid_accounts.destroy_all # Clean slate
+
+    @plaid_provider = mock
+    @snapshot = PlaidItem::AccountsSnapshot.new(@plaid_item, plaid_provider: @plaid_provider)
+  end
+
+  test "fetches accounts" do
+    @plaid_provider.expects(:get_item_accounts).with(@plaid_item.access_token).returns(
+      OpenStruct.new(accounts: [])
+    )
+    @snapshot.accounts
+  end
+
+  test "fetches transactions data if item supports transactions and any accounts present" do
+    @plaid_item.update!(available_products: [ "transactions" ], billed_products: [])
+
+    @snapshot.expects(:accounts).returns([
+      OpenStruct.new(
+        account_id: "123",
+        type: "depository"
+      )
+    ]).at_least_once
+
+    @plaid_provider.expects(:get_transactions).with(@plaid_item.access_token).once
+    @plaid_provider.expects(:get_item_investments).never
+    @plaid_provider.expects(:get_item_liabilities).never
+
+    @snapshot.get_account_data("123")
+  end
+
+  test "does not fetch transactions if no accounts" do
+    @plaid_item.update!(available_products: [ "transactions" ], billed_products: [])
+
+    @snapshot.expects(:accounts).returns([]).at_least_once
+
+    @plaid_provider.expects(:get_transactions).never
+    @plaid_provider.expects(:get_item_investments).never
+    @plaid_provider.expects(:get_item_liabilities).never
+
+    @snapshot.get_account_data("123")
+  end
+
+  test "fetches investments data if item supports investments and investment accounts present" do
+    @plaid_item.update!(available_products: [ "investments" ], billed_products: [])
+
+    @snapshot.expects(:accounts).returns([
+      OpenStruct.new(
+        account_id: "123",
+        type: "investment"
+      )
+    ]).at_least_once
+
+    @plaid_provider.expects(:get_transactions).never
+    @plaid_provider.expects(:get_item_investments).with(@plaid_item.access_token).once
+    @plaid_provider.expects(:get_item_liabilities).never
+
+    @snapshot.get_account_data("123")
+  end
+
+  test "does not fetch investments if no investment accounts" do
+    @plaid_item.update!(available_products: [ "investments" ], billed_products: [])
+
+    @snapshot.expects(:accounts).returns([]).at_least_once
+
+    @plaid_provider.expects(:get_transactions).never
+    @plaid_provider.expects(:get_item_investments).never
+    @plaid_provider.expects(:get_item_liabilities).never
+
+    @snapshot.get_account_data("123")
+  end
+
+  test "fetches liabilities data if item supports liabilities and liabilities accounts present" do
+    @plaid_item.update!(available_products: [ "liabilities" ], billed_products: [])
+
+    @snapshot.expects(:accounts).returns([
+      OpenStruct.new(
+        account_id: "123",
+        type: "credit"
+      )
+    ]).at_least_once
+
+    @plaid_provider.expects(:get_transactions).never
+    @plaid_provider.expects(:get_item_investments).never
+    @plaid_provider.expects(:get_item_liabilities).with(@plaid_item.access_token).once
+
+    @snapshot.get_account_data("123")
+  end
+
+  test "does not fetch liabilities if no liabilities accounts" do
+    @plaid_item.update!(available_products: [ "liabilities" ], billed_products: [])
+
+    @snapshot.expects(:accounts).returns([]).at_least_once
+
+    @plaid_provider.expects(:get_transactions).never
+    @plaid_provider.expects(:get_item_investments).never
+    @plaid_provider.expects(:get_item_liabilities).never
+
+    @snapshot.get_account_data("123")
+  end
+end

test/models/plaid_item/importer_test.rb

@@ -3,21 +3,47 @@ require "ostruct"
 
 class PlaidItem::ImporterTest < ActiveSupport::TestCase
   setup do
-    @mock_provider = PlaidMock.new
+    @mock_provider = mock("Provider::Plaid")
     @plaid_item = plaid_items(:one)
     @importer = PlaidItem::Importer.new(@plaid_item, plaid_provider: @mock_provider)
   end
 
   test "imports item metadata" do
-    PlaidAccount::Importer.any_instance.expects(:import).times(PlaidMock::ACCOUNTS.count)
+    item_data = OpenStruct.new(
+      item_id: "item_1",
+      available_products: [ "transactions", "investments", "liabilities" ],
+      billed_products: [],
+      institution_id: "ins_1",
+      institution_name: "First Platypus Bank",
+    )
 
-    PlaidItem::Importer.new(@plaid_item, plaid_provider: @mock_provider).import
+    @mock_provider.expects(:get_item).with(@plaid_item.access_token).returns(
+      OpenStruct.new(item: item_data)
+    )
 
-    assert_equal PlaidMock::ITEM.institution_id, @plaid_item.institution_id
-    assert_equal PlaidMock::ITEM.available_products, @plaid_item.available_products
-    assert_equal PlaidMock::ITEM.billed_products, @plaid_item.billed_products
+    institution_data = OpenStruct.new(
+      institution_id: "ins_1",
+      institution_name: "First Platypus Bank",
+    )
 
-    assert_equal PlaidMock::ITEM.item_id, @plaid_item.raw_payload["item_id"]
-    assert_equal PlaidMock::INSTITUTION.institution_id, @plaid_item.raw_institution_payload["institution_id"]
+    @mock_provider.expects(:get_institution).with("ins_1").returns(
+      OpenStruct.new(institution: institution_data)
+    )
+
+    PlaidItem::AccountsSnapshot.any_instance.expects(:accounts).returns([
+      OpenStruct.new(
+        account_id: "acc_1",
+        type: "depository"
+      )
+    ]).at_least_once
+
+    PlaidItem::AccountsSnapshot.any_instance.expects(:get_account_data).with("acc_1").once
+
+    PlaidAccount::Importer.any_instance.expects(:import).once
+
+    @plaid_item.expects(:upsert_plaid_snapshot!).with(item_data)
+    @plaid_item.expects(:upsert_plaid_institution_snapshot!).with(institution_data)
+
+    @importer.import
   end
 end