Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-04 21:15:19 +02:00
Code Issues Releases Activity Actions

Improve chart performance and gapfilling (#2306)
Some checks are pending
Publish Docker image / ci (push) Waiting to run
Details
Publish Docker image / Build docker image (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Zach Gollwitzer 2025-05-25 20:40:18 -04:00 • committed by GitHub
parent e1b81ef879
commit 6e202bd7ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 382 additions and 196 deletions
Download patch file Download diff file Expand all files Collapse all files

83
test/models/account/chartable_test.rb
View file

@ -1,61 +1,46 @@
require "test_helper"
class Account::ChartableTest < ActiveSupport::TestCase
test "generates gapfilled balance series" do
test "generates series and memoizes" do
account = accounts(:depository)
account.balances.delete_all
account.balances.create!(date: 20.days.ago.to_date, balance: 5000, currency: "USD")
account.balances.create!(date: 10.days.ago.to_date, balance: 5000, currency: "USD")
test_series = mock
builder1 = mock
builder2 = mock
period = Period.last_30_days
series = account.balance_series(period: period)
assert_equal period.days, series.values.count
assert_equal 0, series.values.first.trend.current.amount
assert_equal 5000, series.values.find { |v| v.date == 20.days.ago.to_date }.trend.current.amount
assert_equal 5000, series.values.find { |v| v.date == 10.days.ago.to_date }.trend.current.amount
assert_equal 5000, series.values.last.trend.current.amount
end
Balance::ChartSeriesBuilder.expects(:new)
.with(
account_ids: [ account.id ],
currency: account.currency,
period: Period.last_30_days,
favorable_direction: account.favorable_direction,
interval: nil
)
.returns(builder1)
.once
test "combines assets and liabilities for multiple accounts properly" do
family = families(:empty)
Balance::ChartSeriesBuilder.expects(:new)
.with(
account_ids: [ account.id ],
currency: account.currency,
period: Period.last_90_days, # Period changed, so memoization should be invalidated
favorable_direction: account.favorable_direction,
interval: nil
)
.returns(builder2)
.once
asset = family.accounts.create!(name: "Asset", currency: "USD", balance: 5000, accountable: Depository.new)
liability = family.accounts.create!(name: "Liability", currency: "USD", balance: 2000, accountable: CreditCard.new)
builder1.expects(:balance_series).returns(test_series).twice
series1 = account.balance_series
memoized_series1 = account.balance_series
asset.balances.create!(date: 20.days.ago.to_date, balance: 4000, currency: "USD")
asset.balances.create!(date: 10.days.ago.to_date, balance: 5000, currency: "USD")
builder2.expects(:balance_series).returns(test_series).twice
builder2.expects(:cash_balance_series).returns(test_series).once
builder2.expects(:holdings_balance_series).returns(test_series).once
liability.balances.create!(date: 20.days.ago.to_date, balance: 1000, currency: "USD")
liability.balances.create!(date: 10.days.ago.to_date, balance: 1500, currency: "USD")
series = family.accounts.balance_series(currency: "USD", period: Period.last_30_days)
assert_equal 0, series.values.first.trend.current.amount
assert_equal 3000, series.values.find { |v| v.date == 20.days.ago.to_date }.trend.current.amount
assert_equal 3500, series.values.last.trend.current.amount
end
test "generates correct totals for multi currency families" do
family = families(:empty)
family.update!(currency: "USD")
usd_account = family.accounts.create!(name: "Asset", currency: "USD", balance: 5000, accountable: Depository.new)
eur_account = family.accounts.create!(name: "Asset", currency: "EUR", balance: 1000, accountable: Depository.new)
usd_account.balances.create!(date: 3.days.ago.to_date, balance: 5000, currency: "USD")
eur_account.balances.create!(date: 3.days.ago.to_date, balance: 1000, currency: "EUR")
# 1 EUR = 1.1 USD, so 1000 EUR = 1100 USD
ExchangeRate.create!(from_currency: "EUR", to_currency: "USD", date: 3.days.ago.to_date, rate: 1.1)
ExchangeRate.create!(from_currency: "EUR", to_currency: "USD", date: 2.days.ago.to_date, rate: 1.1)
ExchangeRate.create!(from_currency: "EUR", to_currency: "USD", date: 1.days.ago.to_date, rate: 1.1)
ExchangeRate.create!(from_currency: "EUR", to_currency: "USD", date: Date.current, rate: 1.1)
series = family.accounts.balance_series(currency: "USD", period: Period.last_7_days)
assert_equal 0, series.values.first.trend.current.amount
assert_equal 6100, series.values.find { |v| v.date == 3.days.ago.to_date }.trend.current.amount
assert_equal 6100, series.values.last.trend.current.amount
series2 = account.balance_series(period: Period.last_90_days)
memoized_series2 = account.balance_series(period: Period.last_90_days)
memoized_series2_cash_view = account.balance_series(period: Period.last_90_days, view: :cash_balance)
memoized_series2_holdings_view = account.balance_series(period: Period.last_90_days, view: :holdings_balance)
end
end