From 70747320c0a3498f8040cf2c4ce0edd3029239f2 Mon Sep 17 00:00:00 2001 From: Jose Farias Date: Thu, 18 Apr 2024 20:54:11 -0600 Subject: [PATCH] Clean up TimeSeries::Trend --- app/models/time_series/trend.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/models/time_series/trend.rb b/app/models/time_series/trend.rb index 5c7bec18..cde8e2c1 100644 --- a/app/models/time_series/trend.rb +++ b/app/models/time_series/trend.rb @@ -26,10 +26,8 @@ class TimeSeries::Trend end def value - if previous.nil? && current.is_a?(Money) - Money.new 0 - elsif previous.nil? - 0 + if previous.nil? + current.is_a?(Money) ? Money.new(0) : 0 else current - previous end @@ -38,7 +36,7 @@ class TimeSeries::Trend def percent if previous.nil? 0.0 - elsif previous == 0 + elsif previous.zero? Float::INFINITY else change = (current_amount - previous_amount).abs