From 7aca5a227704ea15d4b527391aaf6848b99207e2 Mon Sep 17 00:00:00 2001 From: Josh Pigford Date: Wed, 18 Jun 2025 08:38:04 -0500 Subject: [PATCH] Fix remaining rubocop offenses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix string literal style in doorkeeper.rb - Add missing final newlines - Remove trailing whitespace - Fix array bracket spacing in migrations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- config/initializers/doorkeeper.rb | 2 +- config/initializers/doorkeeper_layout.rb | 2 +- config/routes.rb | 2 +- db/migrate/20250618104425_add_source_to_api_keys.rb | 2 +- db/migrate/20250618110104_create_mobile_devices.rb | 2 +- .../20250618110736_add_owner_to_oauth_applications.rb | 2 +- test/controllers/api/v1/auth_controller_test.rb | 8 ++++---- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/config/initializers/doorkeeper.rb b/config/initializers/doorkeeper.rb index 9fe01849..ee13a9a6 100644 --- a/config/initializers/doorkeeper.rb +++ b/config/initializers/doorkeeper.rb @@ -313,7 +313,7 @@ Doorkeeper.configure do # for example. # # Block javascript URIs but allow custom schemes - forbid_redirect_uri { |uri| uri.scheme.to_s.downcase == 'javascript' } + forbid_redirect_uri { |uri| uri.scheme.to_s.downcase == "javascript" } # Allows to set blank redirect URIs for Applications in case Doorkeeper configured # to use URI-less OAuth grant flows like Client Credentials or Resource Owner diff --git a/config/initializers/doorkeeper_layout.rb b/config/initializers/doorkeeper_layout.rb index 42ebdb9a..47d41a65 100644 --- a/config/initializers/doorkeeper_layout.rb +++ b/config/initializers/doorkeeper_layout.rb @@ -3,4 +3,4 @@ Rails.application.config.to_prepare do Doorkeeper::AuthorizationsController.layout "doorkeeper/application" Doorkeeper::AuthorizedApplicationsController.layout "doorkeeper/application" Doorkeeper::ApplicationsController.layout "doorkeeper/application" -end \ No newline at end of file +end diff --git a/config/routes.rb b/config/routes.rb index 8d0976c8..43ca807a 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -189,7 +189,7 @@ Rails.application.routes.draw do post "auth/signup", to: "auth#signup" post "auth/login", to: "auth#login" post "auth/refresh", to: "auth#refresh" - + # Production API endpoints resources :accounts, only: [ :index ] resources :transactions, only: [ :index, :show, :create, :update, :destroy ] diff --git a/db/migrate/20250618104425_add_source_to_api_keys.rb b/db/migrate/20250618104425_add_source_to_api_keys.rb index e773494d..23bad1f6 100644 --- a/db/migrate/20250618104425_add_source_to_api_keys.rb +++ b/db/migrate/20250618104425_add_source_to_api_keys.rb @@ -1,6 +1,6 @@ class AddSourceToApiKeys < ActiveRecord::Migration[7.2] def change add_column :api_keys, :source, :string, default: "web" - add_index :api_keys, [:user_id, :source] + add_index :api_keys, [ :user_id, :source ] end end diff --git a/db/migrate/20250618110104_create_mobile_devices.rb b/db/migrate/20250618110104_create_mobile_devices.rb index 6875e978..ca06ac1b 100644 --- a/db/migrate/20250618110104_create_mobile_devices.rb +++ b/db/migrate/20250618110104_create_mobile_devices.rb @@ -12,6 +12,6 @@ class CreateMobileDevices < ActiveRecord::Migration[7.2] t.timestamps end add_index :mobile_devices, :device_id, unique: true - add_index :mobile_devices, [:user_id, :device_id], unique: true + add_index :mobile_devices, [ :user_id, :device_id ], unique: true end end diff --git a/db/migrate/20250618110736_add_owner_to_oauth_applications.rb b/db/migrate/20250618110736_add_owner_to_oauth_applications.rb index 26b03049..d7913c1d 100644 --- a/db/migrate/20250618110736_add_owner_to_oauth_applications.rb +++ b/db/migrate/20250618110736_add_owner_to_oauth_applications.rb @@ -2,6 +2,6 @@ class AddOwnerToOauthApplications < ActiveRecord::Migration[7.2] def change add_column :oauth_applications, :owner_id, :uuid add_column :oauth_applications, :owner_type, :string - add_index :oauth_applications, [:owner_id, :owner_type] + add_index :oauth_applications, [ :owner_id, :owner_type ] end end diff --git a/test/controllers/api/v1/auth_controller_test.rb b/test/controllers/api/v1/auth_controller_test.rb index 9c021387..959de108 100644 --- a/test/controllers/api/v1/auth_controller_test.rb +++ b/test/controllers/api/v1/auth_controller_test.rb @@ -39,7 +39,7 @@ class Api::V1::AuthControllerTest < ActionDispatch::IntegrationTest assert_equal "newuser@example.com", response_data["user"]["email"] assert_equal "New", response_data["user"]["first_name"] assert_equal "User", response_data["user"]["last_name"] - + # OAuth token assertions assert response_data["access_token"].present? assert response_data["refresh_token"].present? @@ -217,7 +217,7 @@ class Api::V1::AuthControllerTest < ActionDispatch::IntegrationTest assert_equal user.id.to_s, response_data["user"]["id"] assert_equal user.email, response_data["user"]["email"] - + # OAuth token assertions assert response_data["access_token"].present? assert response_data["refresh_token"].present? @@ -351,7 +351,7 @@ class Api::V1::AuthControllerTest < ActionDispatch::IntegrationTest user = users(:family_admin) device = user.mobile_devices.create!(@device_info) oauth_app = device.create_oauth_application! - + # Create initial token initial_token = Doorkeeper::AccessToken.create!( application: oauth_app, @@ -407,4 +407,4 @@ class Api::V1::AuthControllerTest < ActionDispatch::IntegrationTest response_data = JSON.parse(response.body) assert_equal "Refresh token is required", response_data["error"] end -end \ No newline at end of file +end