Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00
Code Issues Releases Activity Actions

Scaffold out Account Syncing (#474)

Browse source 
* Add trends, time series, seed data

* Remove test data

* Replace old view values with helpers

* Fix tooltip bugs in D3 chart

* Fix tests

* Fix smoke test

* Add CRUD actions for valuations

* Scaffold out inline editing with Turbo

* Refactor series logic

* Scaffold out basic sync process for accounts

* Fix tests
This commit is contained in:
Zach Gollwitzer 2024-02-22 11:35:06 -05:00 • committed by GitHub
parent b5b2d335fd
commit 7e324f1b53
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 328 additions and 185 deletions
Download patch file Download diff file Expand all files Collapse all files

60
app/models/account.rb
View file

@ -6,16 +6,32 @@ class Account < ApplicationRecord
delegated_type :accountable, types: Accountable::TYPES, dependent: :destroy
delegate :type_name, to: :accountable
before_create :check_currency
# Show all valuations in history table (no date range filtering)
def valuations_with_trend
series_for(valuations, :value)
def balance_series(period)
filtered_balances = balances.in_period(period).order(:date)
return nil if filtered_balances.empty?
series_data = [ nil, *filtered_balances ].each_cons(2).map do |previous, current|
trend = current&.trend(previous)
{ data: current, trend: { amount: trend&.amount, direction: trend&.direction, percent: trend&.percent } }
end
last_balance = series_data.last[:data]
{
series_data: series_data,
last_balance: last_balance.balance,
trend: last_balance.trend(series_data.first[:data])
}
end
def balances_with_trend(date_range = default_date_range)
series_for(balances, :balance, date_range)
def valuation_series
series_data = [ nil, *valuations.order(:date) ].each_cons(2).map do |previous, current|
{ value: current, trend: current&.trend(previous) }
end
series_data.reverse_each
end
def check_currency
@ -27,36 +43,4 @@ class Account < ApplicationRecord
self.converted_currency = self.family.currency
end
end
private
def default_date_range
{ start: 30.days.ago.to_date, end: Date.today }
end
# TODO: probably a better abstraction for this in the future
def series_for(collection, value_attr, date_range = {})
collection = filtered_by_date_for(collection, date_range)
overall_trend = Trend.new(collection.last&.send(value_attr), collection.first&.send(value_attr))
collection_with_trends = [ nil, *collection ].each_cons(2).map do |previous, current|
{
current: current,
previous: previous,
date: current.date,
currency: current.currency,
value: current.send(value_attr),
trend: Trend.new(current.send(value_attr), previous&.send(value_attr))
}
end
{ date_range: date_range, trend: overall_trend, series: collection_with_trends }
end
def filtered_by_date_for(association, date_range)
scope = association
scope = scope.where("date >= ?", date_range[:start]) if date_range[:start]
scope = scope.where("date <= ?", date_range[:end]) if date_range[:end]
scope.order(:date).to_a
end
end