Fix translation scope within modals (#404)

* Patch virtual_path within modal helper

Added an example translation within the modal to test.

* Fix modal translation scope

By changing this to a partial that accepts the content via a local var
instead of a layout the virtual path, and therefore translation scope is
not changed.

app/helpers/application_helper.rb

@@ -14,6 +14,7 @@ module ApplicationHelper
   # Wrap view with <%= modal do %> ... <% end %> to have it open in a modal
   # Make sure to add data-turbo-frame="modal" to the link/button that opens the modal
   def modal(&block)
-    render "shared/modal", &block
+    content = capture &block
+    render partial: "shared/modal", locals: { content: content }
   end
 end

app/views/accounts/new.html.erb

@@ -3,7 +3,7 @@
 <%= modal do %>
   <% if params[:type].blank? || Account.accountable_types.include?("Account::#{params[:type]}") == false %>
     <div class="border-b border-[#141414]/2 p-4 text-gray-400">
-      What would you like to add?
+      <%= t '.select_accountable_type' %>
     </div>
     <div class="flex flex-col p-2 text-sm" data-controller="list-keyboard-navigation">
       <button hidden data-controller="hotkey" data-hotkey="k,K,ArrowUp,ArrowLeft" data-action="list-keyboard-navigation#focusPrevious">Previous</button>

app/views/shared/_modal.html.erb

@@ -1,7 +1,8 @@
+<%# locals: (content:) -%>
 <%= turbo_frame_tag "modal" do %>
   <dialog class="bg-white border border-[#141414]/25 rounded-2xl max-h-[556px] max-w-[580px] w-full shadow-xs" data-controller="modal" data-action="click->modal#click_outside">
     <div class="flex flex-col h-full">
-      <%= yield %>
+      <%= content %>
     </div>
   </dialog>
 <% end %>

config/locales/views/account/en.yml

@@ -6,4 +6,5 @@ en:
     index:
       title: Cash
     new:
+      select_accountable_type: What would you like to add?
       title: Add an account