Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00
Code Issues Releases Activity Actions

Fix transfers and form currencies (#1477)
Some checks are pending
Publish Docker image / ci (push) Waiting to run
Details
Publish Docker image / Build docker image (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Zach Gollwitzer 2024-11-18 15:50:47 -05:00 • committed by GitHub
parent fcb95207d7
commit 81d604f3d4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 41 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/models/account/transfer.rb
View file

@ -49,7 +49,7 @@ class Account::Transfer < ApplicationRecord
end
class << self
def build_from_accounts(from_account, to_account, date:, amount:, currency:)
def build_from_accounts(from_account, to_account, date:, amount:)
outflow = from_account.entries.build \
amount: amount.abs,
currency: from_account.currency,
@ -58,9 +58,17 @@ class Account::Transfer < ApplicationRecord
marked_as_transfer: true,
entryable: Account::Transaction.new
# Attempt to convert the amount to the to_account's currency. If the conversion fails,
# use the original amount.
converted_amount = begin
Money.new(amount.abs, from_account.currency).exchange_to(to_account.currency)
rescue Money::ConversionError
Money.new(amount.abs, from_account.currency)
end
inflow = to_account.entries.build \
amount: amount.abs * -1,
currency: from_account.currency,
amount: converted_amount.amount * -1,
currency: converted_amount.currency.iso_code,
date: date,
name: "Transfer from #{from_account.name}",
marked_as_transfer: true,