Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-24 15:49:39 +02:00
Code Issues Releases Activity Actions 1

fix: amend inputs on loan, c.c., vehicle, and property partials (#1281)

Browse source 
* fix: use number inputs on partial loan and credit card form views

* amend vehicle partial

* amend property inputs

* fix lint

* Update app/views/accounts/accountables/_credit_card.html.erb

Co-authored-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Signed-off-by: Guillem Arias Fauste <gariasf@proton.me>

* Update app/views/accounts/accountables/_loan.html.erb

Co-authored-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Signed-off-by: Guillem Arias Fauste <gariasf@proton.me>

---------

Signed-off-by: Guillem Arias Fauste <gariasf@proton.me>
Co-authored-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>
This commit is contained in:
Guillem Arias Fauste 2024-10-10 16:45:17 +02:00 • committed by GitHub
parent 977da34efc
commit 90278630ed
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/views/accounts/accountables/_credit_card.html.erb
View file

@ -4,17 +4,17 @@
<div class="space-y-2">
<%= f.fields_for :accountable do |credit_card_form| %>
<div class="flex items-center gap-2">
<%= credit_card_form.text_field :available_credit, label: t(".available_credit"), placeholder: t(".available_credit_placeholder") %>
<%= credit_card_form.number_field :available_credit, label: t(".available_credit"), placeholder: t(".available_credit_placeholder"), min: 0 %>
</div>
<div class="flex items-center gap-2">
<%= credit_card_form.text_field :minimum_payment, label: t(".minimum_payment"), placeholder: t(".minimum_payment_placeholder") %>
<%= credit_card_form.text_field :apr, label: t(".apr"), placeholder: t(".apr_placeholder") %>
<%= credit_card_form.number_field :minimum_payment, label: t(".minimum_payment"), placeholder: t(".minimum_payment_placeholder"), min: 0 %>
<%= credit_card_form.number_field :apr, label: t(".apr"), placeholder: t(".apr_placeholder"), min: 0, step: 0.01 %>
</div>
<div class="flex items-center gap-2">
<%= credit_card_form.date_field :expiration_date, label: t(".expiration_date") %>
<%= credit_card_form.text_field :annual_fee, label: t(".annual_fee"), placeholder: t(".annual_fee_placeholder") %>
<%= credit_card_form.number_field :annual_fee, label: t(".annual_fee"), placeholder: t(".annual_fee_placeholder"), min: 0 %>
</div>
<% end %>
</div>

2
app/views/accounts/accountables/_loan.html.erb
View file

@ -4,7 +4,7 @@
<div class="space-y-2">
<%= f.fields_for :accountable do |loan_form| %>
<div class="flex items-center gap-2">
<%= loan_form.text_field :interest_rate, label: t(".interest_rate"), placeholder: t(".interest_rate_placeholder") %>
<%= loan_form.number_field :interest_rate, label: t(".interest_rate"), placeholder: t(".interest_rate_placeholder"), min: 0, step: 0.01 %>
<%= loan_form.select :rate_type, options_for_select([["Fixed", "fixed"], ["Variable", "variable"], ["Adjustable", "adjustable"]]), { label: t(".rate_type") } %>
</div>

4
app/views/accounts/accountables/_property.html.erb
View file

@ -8,8 +8,8 @@
<div class="space-y-2">
<%= f.fields_for :accountable do |af| %>
<div class="flex gap-2">
<%= af.number_field :year_built, label: t(".year_built"), placeholder: 2005 %>
<%= af.number_field :area_value, label: t(".area_value"), placeholder: 2000 %>
<%= af.number_field :year_built, label: t(".year_built"), placeholder: 2005, min: 1700, max: Time.current.year %>
<%= af.number_field :area_value, label: t(".area_value"), placeholder: 2000, min: 1 %>
<%= af.select :area_unit,
[["Square feet", "sqft"], ["Square meters", "sqm"]],
{ label: t(".area_unit") } %>

4
app/views/accounts/accountables/_vehicle.html.erb
View file

@ -12,8 +12,8 @@
</div>
<div class="flex items-center gap-2">
<%= vehicle_form.text_field :year, label: t(".year"), placeholder: t(".year_placeholder") %>
<%= vehicle_form.text_field :mileage_value, label: t(".mileage"), placeholder: t(".mileage_placeholder") %>
<%= vehicle_form.number_field :year, label: t(".year"), placeholder: t(".year_placeholder"), min: 1900, max: Time.current.year %>
<%= vehicle_form.number_field :mileage_value, label: t(".mileage"), placeholder: t(".mileage_placeholder"), min: 0 %>
<%= vehicle_form.select :mileage_unit,
[["Miles", "mi"], ["Kilometers", "km"]],
{ label: t(".mileage_unit") } %>